Skip to content

InProc datacollector flow changes for passing test sources #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vagisha-nidhi merged 12 commits into from
Apr 3, 2019
Merged

InProc datacollector flow changes for passing test sources #1969

vagisha-nidhi merged 12 commits into from
Apr 3, 2019

Conversation

@vagisha-nidhi
Copy link
Contributor

@vagisha-nidhi vagisha-nidhi commented Mar 25, 2019 •
edited
Loading

Description

1. Adding inproc data collector for coverlet in argument processor.
Adding <InProcDataCollector friendlyName=”XPlat Code Coverage” codebase=”{codebase}” assemblyQualifiedName=”{assemblyQualifiedName}”/> in collect argument processor for CLI scenarios in case of XPlat code coverage.

2. Passing test sources to inproc data collector sessionstartevent
This PR includes flow changes to pass test sources in TestSessionStartArgs

3. Using default code base to initialize inproc data collector in case code base given is relative.
Using default code base to initialize inproc data collector in case codebase given is relative.
Inproc data collector requires codebase in runsettings to work. If codebase is not present, then we skip the data collector and log an error in EqtTrace presently. We will now use a default codebase passed.

abhishkk
abhishkk reviewed Mar 27, 2019
View reviewed changes
@abhishkk
Copy link
Contributor

abhishkk commented Mar 27, 2019

Description

Inproc data collector requires codebase in runsettings to work. If codebase is not present, then we skip the data collector and log an error in EqtTrace.
This PR includes flow changes to pass test sources, from which Test assembly path will be determined incase inproc datacollector runsettings does not contain full codebase path.

We also add <InProcDataCollector friendlyName=”XPlat Code Coverage” codebase=”coverletinprocdatacollector.dll” assemblyQualifiedName=”{assemblyQualifiedName}”/> in collect argument processor for CLI scenarios in case of XPlat code coverage.

Write separate points about the different works which are happening in this pr as there is no separate RFC for this:

  1. Adding inproc data collector for coverlet in argument processor.
  2. Passing test sources to inproc data collector sessionstartevent
  3. Using default code base to initialize inproc data collector in case code base given is relative.

@abhishkk
Copy link
Contributor

abhishkk commented Apr 2, 2019

Test run selected scenario for blame and inproc data collector

abhishkk
abhishkk approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@abhishkk abhishkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

...icrosoft.TestPlatform.CrossPlatEngine/DataCollection/InProcDataCollectionExtensionManager.cs Outdated
{
TestSessionStartArgs testSessionStartArgs = new TestSessionStartArgs();
var properties = new Dictionary<string, object>();
properties.Add(Constants.TestSourcesPropertyName, e.GetPropertyValue<IEnumerable<string>>(Constants.TestSourcesPropertyName));
Copy link
Contributor

@abhishkk abhishkk Apr 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move it to separate private method GetSessionStartProperties

src/vstest.console/Processors/CollectArgumentProcessor.cs Outdated

/// TODO : Finalize Name
/// <summary>
/// Coverlet data collector assembly qualified name
Copy link
Contributor

@abhishkk abhishkk Apr 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverlet in proc data collector assembly qualified name.
Change in CoverletDataCollectorCodebase as well.

@vagisha-nidhi vagisha-nidhi merged commit 4b574c2 into microsoft:master Apr 3, 2019
This was referenced May 16, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@abhishkk abhishkk abhishkk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vagisha-nidhi @abhishkk @singhsarab