Include traits from TestCase in TRX output

[agehrke]

In the current TRX logger implementation, traits on TestCase objects are mostly ignored when converting to the internal ITestElement/UnitTestElement representation.

This PR adds a TestPropertyItemCollection TestProperties property on TestElement class which is populated when converting a TestCase in Converter.ToTestElement() method. TestElement.Save() method is then extended to store the test properties (traits) as Key/Value elements under a Properties element - this follows the XML schema from vstst.xsd.

Example of trx output with traits:

  <TestDefinitions>
    <UnitTest name="TestCaseWithTraits" storage="dummysourcefilename" id="0e9d09de-c08c-235d-bc82-88a161ff28aa">
      <Properties>
        <Property>
          <Key>Trait1</Key>
          <Value>Value1</Value>
        </Property>
        <Property>
          <Key>Trait2</Key>
          <Value>Value2</Value>
        </Property>
      </Properties>
      <Execution id="3612b533-5190-45e7-a28b-96a584ade89d" />
      <TestMethod codeBase="DummySourceFileName" adapterTypeName="some://uri/" className="DummySourceFileName" name="TestCaseWithTraits" />
    </UnitTest>
  </TestDefinitions>

Most of this work is based on @dotMorten's PR #1801.

Tests

I have implemented a test for converting a TestCase with traits, and a test for validating the TRX output of a test with traits.

[msftclas]

All CLA requirements met.

[agehrke]

It seems the test ProcessRequestsShouldProcessMessagesUntilSessionCompleted fails on build agent. It works locally and I haven't touched anything in that area.

[agehrke]

@mayankbansal018 can I do something to make it easier for you to review this PR?

[mayankbansal018]

@agehrke I've been a bit busy with a few thing, will I'll look into this over the weekend

[agehrke]

No rush, I completely understand that you have other more important tasks 🙂

[singhsarab]

https://blog.paranoidcoding.com/2019/04/08/string-vs-String-is-not-about-style.html

[mayankbansal018]

@agehrke The changes look good, but have we validated that the trx generated after these changes still opens correctly in VS?

[singhsarab]

@mayankbansal018 Please follow up on this.

[Evangelink]

Hi @agehrke, I know the PR is quite old but would you be ready to fix the conflicts? I will try to do the follow-up.

[agehrke]

@Evangelink Yes, of course. I will rebase PR on main branch this weekend and push it. Thanks

[agehrke]

I have rebased on main and adjusted changes to new code guidelines (field names, file scoped namespace, etc)

[agehrke]

@Evangelink Let me know if you need something more from me.

[Evangelink]

Hi @agehrke,

Sorry for the delay! I am new to the team and it seems like I went ahead a little too quick here :(. We reviewed the change internally and we decided to add versioning to TRX, before merging this PR. This way users can check if the properties you are adding should be present in the file or not.

I'd like to still say a big thank you for the contribution and for the quick update!

[Evangelink]

Hi @agehrke,

It's unlikely we will move forward with this PR so I will close it.

Once again thank you for the contribution.