Skip to content

Fixing the connection timeout #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
singhsarab merged 2 commits into from
Feb 3, 2019
Merged

Fixing the connection timeout #1910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59c110c
Fix the connection timeout for design mode client and socket communic…
singhsarab Feb 3, 2019
9cecdd9
Reaction based on the test failure.
singhsarab Feb 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Microsoft.TestPlatform.Client/DesignMode/DesignModeClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,10 @@ public void ConnectToClientAndProcessRequests(int port, ITestRequestManager test
EqtTrace.Info("Trying to connect to server on port : {0}", port);
this.communicationManager.SetupClientAsync(new IPEndPoint(IPAddress.Loopback, port));

var connectionTimeout = EnvironmentHelper.GetConnectionTimeout();
var connectionTimeoutInSecs = EnvironmentHelper.GetConnectionTimeout();

// Wait for the connection to the server and listen for requests.
if (this.communicationManager.WaitForServerConnection(connectionTimeout))
if (this.communicationManager.WaitForServerConnection(connectionTimeoutInSecs * 1000))
{
this.communicationManager.SendMessage(MessageType.SessionConnected);
this.ProcessRequests(testRequestManager);
Expand All @@ -113,7 +113,7 @@ public void ConnectToClientAndProcessRequests(int port, ITestRequestManager test
CommunicationUtilitiesResources.ConnectionTimeoutErrorMessage,
CoreUtilitiesConstants.VstestConsoleProcessName,
"translation layer",
connectionTimeout,
connectionTimeoutInSecs,
EnvironmentHelper.VstestConnectionTimeout)
);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.TestPlatform.CommunicationUtilities/SocketCommunicationManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public async Task SetupClientAsync(IPEndPoint endpoint)

Stopwatch watch = new Stopwatch();
watch.Start();
var connectionTimeout = EnvironmentHelper.GetConnectionTimeout();
var connectionTimeout = EnvironmentHelper.GetConnectionTimeout() * 1000;
do
{
try
Expand Down