Bug Fix running NETFramework 3.5 in compat mode #1906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhsarab
reviewed
Jan 31, 2019
| </data> | ||
| <data name="Framework35NotSupported" xml:space="preserve"> | ||
| <value>Framework35 is not supported. For projects targeting .Net Framework 3.5, please use Framework40 to run tests in CLR 4.0 "compatibility mode".</value> | ||
| <value>Framework35 is not supported. For projects targeting .Net Framework 3.5, tests are running in "compatibility mode".</value> |
Contributor
There was a problem hiding this comment.
Framework35 is not supported. For projects targeting .Net Framework 3.5, test will run in CLR 4.0 "compatibility mode".
singhsarab
approved these changes
Jan 31, 2019
Contributor
singhsarab
left a comment
singhsarab
left a comment
There was a problem hiding this comment.
Please change the string and attach the final output users sees. Approving with suggestions.
Contributor
|
@vagisha-nidhi Please validate the VS scenario before pushing this in. |
singhsarab
pushed a commit
to singhsarab/vstest
that referenced
this pull request
Mar 5, 2019
* Bug Fix running NETFramework 3.5 in compat mode
singhsarab
added a commit
that referenced
this pull request
Mar 5, 2019
* Translation Layer connection timeout (#1843) * Adding the missing assemblyInfo files and updating the copyrights (#1859) * Stop trying to connect if the test host exits unexpectedly (#1853) * Running NETFramework 3.5 in compat mode (#1906) * Fixing the timeouts. (#1909) * Fixing the connection timeout (#1910) * TestPlatform.PR (#1837)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test projects targeting .NetFramework 3.5 throw error.
Change : We will run these tests in compat mode(default using .NetFramework 4.0)
We are unable to get information from assembly metadata for a .NetFramework 3.5 project, hence by default .NetFramework 4.0 is chosen as the running framework.
Related issue
#1896