-
Notifications
You must be signed in to change notification settings - Fork 336
Aborting test run when source and target frameworks/architectures are incompatible #1789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vagisha-nidhi
merged 30 commits into
microsoft:master
from
vagisha-nidhi:TargetingDifferentFrameworks
Feb 13, 2019
Merged
Changes from 9 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
f60b214
ExceptionWhenTargetingDiffFramworksPlat
vagisha-nidhi 0a8e968
Acceptance tests updated
vagisha-nidhi ce5de2f
Merge branch 'master' of https://github.com/Microsoft/vstest into Tar…
vagisha-nidhi 37fa219
Message change in conflict dlls
vagisha-nidhi 75e2164
Changes in methods
vagisha-nidhi 92fe52c
Merge branch 'master' of https://github.com/Microsoft/vstest into Tar…
vagisha-nidhi 9943636
minor fix in test
vagisha-nidhi 30ebd14
fix in test
vagisha-nidhi e6230ba
improved error message
vagisha-nidhi 3fa02c1
PR comments
vagisha-nidhi ce59bb3
fix acceptance test
vagisha-nidhi d7057e2
Merge branch 'master' of https://github.com/Microsoft/vstest into Tar…
vagisha-nidhi 220c955
Refactoring InferRunSettingsHelper
vagisha-nidhi c9740ea
Refactor
vagisha-nidhi e4f233f
Merge branch 'master' into TargetingDifferentFrameworks
vagisha-nidhi 2e66caa
Tests updated
vagisha-nidhi 550b4cc
Merge branch 'TargetingDifferentFrameworks' of https://github.com/vag…
vagisha-nidhi 10bc3f3
Update TestRequestManager.cs
vagisha-nidhi ed39fbd
Restructured and Added test
vagisha-nidhi 58b3dfa
Merge branch 'TargetingDifferentFrameworks' of https://github.com/vag…
vagisha-nidhi bc8c120
Update TestRequestManager.cs
vagisha-nidhi e850846
minor change
vagisha-nidhi b033b87
Merge branch 'TargetingDifferentFrameworks' of https://github.com/vag…
vagisha-nidhi 3d5b844
minor change
vagisha-nidhi 615fbac
Merge branch 'master' into TargetingDifferentFrameworks
vagisha-nidhi 35ba9e5
Merge branch 'master' of https://github.com/Microsoft/vstest into Tar…
vagisha-nidhi 1ddc150
Merge branch 'master' into TargetingDifferentFrameworks
vagisha-nidhi 6bcc76c
Modified logic in IsFrameworkIncompatible
vagisha-nidhi 7836605
Merge branch 'TargetingDifferentFrameworks' of https://github.com/vag…
vagisha-nidhi 53b609b
Removing unused variable
vagisha-nidhi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some redundancies and message looks very big.
How about. "The following DLL(s) do not match the specified framework {0} and platform {1} settings.{2}Ensure sure the test assemblies target the specified framework/platform settings. Go to {3} for more details on managing these settings."
/cc: @PBoraMSFT #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Message updated #Resolved