Skip to content

Report raw invalid value for the remaining RunConfiguration bool settings #16296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jakub Jareš (nohwnd) wants to merge 2 commits into from
Closed

Report raw invalid value for the remaining RunConfiguration bool settings #16296

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2146908
Report raw invalid value for the remaining RunConfiguration bool sett…
nohwnd Jul 20, 2026
1f47c61
Report raw invalid value for IsTargetPlatformInferred
nohwnd Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.TestPlatform.ObjectModel/RunSettings/RunConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,7 +1030,7 @@ public static RunConfiguration FromXml(XmlReader reader)
if (!bool.TryParse(element, out boolValue))
{
throw new SettingsException(string.Format(CultureInfo.CurrentCulture,
Resources.Resources.InvalidSettingsIncorrectValue, Constants.RunConfigurationSettingsName, boolValue, elementName));
Resources.Resources.InvalidSettingsIncorrectValue, Constants.RunConfigurationSettingsName, element, elementName));
}
Comment on lines 1024 to 1034

runConfiguration.DisableSharedTestHost = boolValue;
Expand All @@ -1046,7 +1046,7 @@ public static RunConfiguration FromXml(XmlReader reader)
if (!bool.TryParse(element, out boolValue))
{
throw new SettingsException(string.Format(CultureInfo.CurrentCulture,
Resources.Resources.InvalidSettingsIncorrectValue, Constants.RunConfigurationSettingsName, boolValue, elementName));
Resources.Resources.InvalidSettingsIncorrectValue, Constants.RunConfigurationSettingsName, element, elementName));
}
Comment thread
nohwnd marked this conversation as resolved.
Resolved

runConfiguration.SkipDefaultAdapters = boolValue;
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ public virtual TestProcessStartInfo GetTestHostProcessStartInfo(
EqtTrace.Verbose($"DotnetTestHostmanager: Searching muxer for the architecture '{targetArchitecture}', OS '{_platformEnvironment.OperatingSystem}' framework '{_targetFramework}' SDK platform architecture '{_platformEnvironment.Architecture}'");
if (forceToX64)
{
EqtTrace.Verbose($"DotnetTestHostmanager: Forcing the search to x64 architecure, IsDefaultTargetArchitecture '{_isDefaultTargetArchitecture}' OS '{_platformEnvironment.OperatingSystem}' framework '{_targetFramework}'");
EqtTrace.Verbose($"DotnetTestHostmanager: Forcing the search to x64 architecture, IsTargetPlatformInferred '{_isDefaultTargetArchitecture}' OS '{_platformEnvironment.OperatingSystem}' framework '{_targetFramework}'");
}

// Check if DOTNET_ROOT resolution should be bypassed.
Expand Down
32 changes: 32 additions & 0 deletions test/Microsoft.TestPlatform.ObjectModel.UnitTests/RunSettings/RunConfigurationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,4 +447,36 @@ public void RunConfigurationFromXmlThrowsSettingsExceptionIfIsTargetPlatformInfe
Assert.ThrowsExactly<SettingsException>(
() => XmlRunSettingsUtilities.GetRunConfigurationNode(settingsXml));
}

[TestMethod]
public void RunConfigurationFromXmlThrowsSettingsExceptionIfDisableSharedTestHostIsInvalid()
{
string settingsXml =
@"<?xml version=""1.0"" encoding=""utf-8""?>
Comment thread
nohwnd marked this conversation as resolved.
Resolved
<RunSettings>
<RunConfiguration>
<DisableSharedTestHost>InvalidValue</DisableSharedTestHost>
</RunConfiguration>
</RunSettings>";

var exception = Assert.ThrowsExactly<SettingsException>(
() => XmlRunSettingsUtilities.GetRunConfigurationNode(settingsXml));
Assert.AreEqual("Invalid settings 'RunConfiguration'. Invalid value 'InvalidValue' specified for 'DisableSharedTestHost'.", exception.Message);
}

[TestMethod]
public void RunConfigurationFromXmlThrowsSettingsExceptionIfSkipDefaultAdaptersIsInvalid()
{
string settingsXml =
@"<?xml version=""1.0"" encoding=""utf-8""?>
<RunSettings>
<RunConfiguration>
<SkipDefaultAdapters>InvalidValue</SkipDefaultAdapters>
</RunConfiguration>
</RunSettings>";

var exception = Assert.ThrowsExactly<SettingsException>(
() => XmlRunSettingsUtilities.GetRunConfigurationNode(settingsXml));
Assert.AreEqual("Invalid settings 'RunConfiguration'. Invalid value 'InvalidValue' specified for 'SkipDefaultAdapters'.", exception.Message);
}
}