Skip to content

Remove auto-approve for maestro PRs - #16188

Merged
Jakub Jareš (nohwnd) merged 1 commit into
microsoft:mainfrom
nohwnd:nohwnd-remove-codeflow-auto-approve
Jun 29, 2026
Merged

Remove auto-approve for maestro PRs#16188
Jakub Jareš (nohwnd) merged 1 commit into
microsoft:mainfrom
nohwnd:nohwnd-remove-codeflow-auto-approve

Conversation

@nohwnd

@nohwnd Jakub Jareš (nohwnd) commented Jun 29, 2026

Copy link
Copy Markdown
Member

The .github/policies/PullRequestIssueManagement policy auto-approves every PR opened by dotnet-maestro. That approval shows up as a review on codeflow PRs (e.g. #16185) and fights with the Maestro auto-merge checks, leaving the PR red instead of just merging on its own. Dropping the policy file removes the auto-approve; auto-merge still gates on the real checks. Added in #15598.

image

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Auto-approving codeflow PRs adds an approval review that conflicts with the auto-merge checks. Drop the policy that does it.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 29, 2026 07:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the GitOps PullRequestIssueManagement policy that automatically approved PRs opened by dotnet-maestro[bot], avoiding the extra auto-review that can interfere with Maestro’s auto-merge behavior on codeflow PRs.

Changes:

  • Delete the .github/policies/PullRequestIssueManagement policy that triggered approvePullRequest on PR open events from dotnet-maestro[bot].

@nohwnd
Jakub Jareš (nohwnd) merged commit 11cad50 into microsoft:main Jun 29, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants