Skip to content
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,10 @@
namespace Microsoft.TestPlatform.AcceptanceTests;

[TestClass]
[TestCategory("Windows-Review")]
public class ArgumentProcessorTests : AcceptanceTestBase
{

[TestMethod]
[TestCategory("Windows-Review")]
[NetFullTargetFrameworkDataSource]
public void PassingNoArgumentsToVsTestConsoleShouldPrintHelpMessage(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
Comment thread
nohwnd marked this conversation as resolved.
{
Expand All @@ -34,7 +32,6 @@ public void PassingNoArgumentsToVsTestConsoleShouldPrintHelpMessage(RunnerInfo r
}

[TestMethod]
[TestCategory("Windows-Review")]
[NetFullTargetFrameworkDataSource]
public void PassingInvalidArgumentsToVsTestConsoleShouldNotPrintHelpMessage(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ public void DataCollectorAssemblyLoadingShouldNotThrowErrorForNetCore(RunnerInfo
}

[TestMethod]
[TestCategory("Windows-Review")]
[NetFullTargetFrameworkDataSource]
public void DataCollectorAssemblyLoadingShouldNotThrowErrorForFullFramework(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ public void MultipleSourcesDiscoverAllTests(RunnerInfo runnerInfo)
}

[TestMethod]
[TestCategory("Windows-Review")]
[NetFullTargetFrameworkDataSource(inIsolation: true, inProcess: true)]
public void DiscoverFullyQualifiedTests(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
Comment thread
nohwnd marked this conversation as resolved.
{
Expand Down Expand Up @@ -119,7 +118,6 @@ public void TypesToLoadAttributeTests()
}

[TestMethod]
[TestCategory("Windows-Review")]
[NetFullTargetFrameworkDataSource(inIsolation: true, inProcess: true)]
public void DiscoverTestsShouldSucceedWhenAtLeastOneDllFindsRuntimeProvider(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ namespace Microsoft.TestPlatform.AcceptanceTests;
public class DotnetTestMSBuildOutputTests : AcceptanceTestBase
{
[TestMethod]
// patched dotnet is not published on non-windows systems
[TestCategory("Windows-Review")]
[NetCoreTargetFrameworkDataSource(useDesktopRunner: false)]
public void MSBuildLoggerCanBeEnabledByBuildPropertyAndDoesNotEatSpecialChars(RunnerInfo runnerInfo)
{
Expand Down Expand Up @@ -54,8 +52,6 @@ public void MSBuildLoggerCanBeEnabledByBuildPropertyAndDoesNotEatSpecialChars(Ru
}

[TestMethod]
// patched dotnet is not published on non-windows systems
[TestCategory("Windows-Review")]
[NetCoreTargetFrameworkDataSource(useDesktopRunner: false)]
public void MSBuildLoggerCanBeDisabledByBuildProperty(RunnerInfo runnerInfo)
{
Expand All @@ -74,8 +70,6 @@ public void MSBuildLoggerCanBeDisabledByBuildProperty(RunnerInfo runnerInfo)


[TestMethod]
// patched dotnet is not published on non-windows systems
[TestCategory("Windows-Review")]
[NetCoreTargetFrameworkDataSource(useDesktopRunner: false)]
public void MSBuildLoggerCanBeDisabledByEnvironmentVariableProperty(RunnerInfo runnerInfo)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ namespace Microsoft.TestPlatform.AcceptanceTests;
[TestClass]
public class ExecutionTests : AcceptanceTestBase
{
//TODO: It looks like the first 3 tests would be useful to multiply by all 3 test frameworks, should we make the test even more generic, or duplicate them?
[TestMethod]
[TestCategory("Windows-Review")]
[MSTestCompatibilityDataSource]
public void RunMultipleTestAssemblies(RunnerInfo runnerInfo)
Comment on lines 19 to 23

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, and that's exactly why this one keeps [TestCategory("Windows-Review")] — I re-added it in 97c8d34. The compat-matrix net48 desktop runner can't start on Linux/macOS, so the test stays Windows-only. ubuntu + macOS are green in build 1480079.

{
Expand All @@ -35,7 +33,6 @@ public void RunMultipleTestAssemblies(RunnerInfo runnerInfo)
}

[TestMethod]
[TestCategory("Windows-Review")]
[TestHostCompatibilityDataSource]
public void RunMultipleMSTestAssembliesOnVstestConsoleAndTesthostCombinations(RunnerInfo runnerInfo)
{
Comment thread
nohwnd marked this conversation as resolved.
Expand All @@ -52,7 +49,6 @@ public void RunMultipleMSTestAssembliesOnVstestConsoleAndTesthostCombinations(Ru
}

[TestMethod]
[TestCategory("Windows-Review")]
[RunnerCompatibilityDataSource]
public void RunMultipleMSTestAssembliesOnVstestConsoleAndTesthostCombinations2(RunnerInfo runnerInfo)
{
Comment thread
nohwnd marked this conversation as resolved.
Expand All @@ -67,7 +63,6 @@ public void RunMultipleMSTestAssembliesOnVstestConsoleAndTesthostCombinations2(R
}

[TestMethod]
[TestCategory("Windows-Review")]
[TestCategory("Smoke")]
[NetFullTargetFrameworkDataSource(inIsolation: true, inProcess: true, useVsixRunner: true)]
[NetCoreTargetFrameworkDataSource]
Expand Down Expand Up @@ -292,7 +287,6 @@ public void IncompatibleSourcesWarningShouldBeDisplayedInTheConsoleOnlyWhenRunni
}

[TestMethod]
[TestCategory("Windows-Review")]
[NetFullTargetFrameworkDataSource]
public void ExitCodeShouldReturnOneWhenTreatNoTestsAsErrorParameterSetToTrueAndNoTestMatchesFilter(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
Comment thread
nohwnd marked this conversation as resolved.
{
Expand All @@ -312,7 +306,6 @@ public void ExitCodeShouldReturnOneWhenTreatNoTestsAsErrorParameterSetToTrueAndN
}

[TestMethod]
[TestCategory("Windows-Review")]
[NetFullTargetFrameworkDataSource]
public void ExitCodeShouldReturnZeroWhenTreatNoTestsAsErrorParameterSetToFalseAndNoTestMatchesFilter(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
{
Expand Down Expand Up @@ -366,7 +359,6 @@ public void ExitCodeShouldNotDependOnFailTreatNoTestsAsErrorFalseValueWhenThereA
}

[TestMethod]
[TestCategory("Windows-Review")]
[NetFullTargetFrameworkDataSource(inIsolation: true, inProcess: true)]
public void ExecuteTestsShouldSucceedWhenAtLeastOneDllFindsRuntimeProvider(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ public void FrameworkShortNameArgumentShouldWork(RunnerInfo runnerInfo)
}

[TestMethod]
// framework runner not available on Linux
[TestCategory("Windows-Review")]
[NetFullTargetFrameworkDataSource(useCoreRunner: false)]
//[NetCoreTargetFrameworkDataSource]
public void OnWrongFrameworkPassedTestRunShouldNotRun(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
Expand All @@ -69,7 +67,6 @@ public void OnWrongFrameworkPassedTestRunShouldNotRun(RunnerInfo runnerInfo)
[TestMethod]
[NetFullTargetFrameworkDataSource]
[NetCoreTargetFrameworkDataSource]
[TestCategory("Windows-Review")]
public void RunSpecificTestsShouldWorkWithFrameworkInCompatibleWarning(RunnerInfo runnerInfo)
{
SetTestEnvironment(_testEnvironment, runnerInfo);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ namespace Microsoft.TestPlatform.AcceptanceTests;
public class LoggerTests : AcceptanceTestBase
{
[TestMethod]
[TestCategory("Windows-Review")]
[NetFullTargetFrameworkDataSource(inIsolation: true, inProcess: true)]
public void TrxLoggerWithFriendlyNameShouldProperlyOverwriteFile(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
Comment thread
nohwnd marked this conversation as resolved.
{
Expand All @@ -36,7 +35,6 @@ public void TrxLoggerWithFriendlyNameShouldProperlyOverwriteFile(RunnerInfo runn
}

[TestMethod]
[TestCategory("Windows-Review")]
[NetFullTargetFrameworkDataSource(inIsolation: true, inProcess: true)]
public void HtmlLoggerWithFriendlyNameShouldProperlyOverwriteFile(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
{
Expand All @@ -57,7 +55,6 @@ public void HtmlLoggerWithFriendlyNameShouldProperlyOverwriteFile(RunnerInfo run
}

[TestMethod]
[TestCategory("Windows-Review")]
[NetFullTargetFrameworkDataSource(inIsolation: true, inProcess: true)]
public void HtmlLoggerWithFriendlyNameContainsExpectedContent(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
{
Expand Down Expand Up @@ -105,7 +102,6 @@ public void TrxLoggerWithExecutorUriShouldProperlyOverwriteFile(RunnerInfo runne
}

[TestMethod]
[TestCategory("Windows-Review")]
[NetFullTargetFrameworkDataSource(inIsolation: true, inProcess: true)]
public void TrxLoggerWithLogFilePrefixShouldGenerateMultipleTrx(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
{
Expand Down Expand Up @@ -146,7 +142,6 @@ public void HtmlLoggerWithExecutorUriShouldProperlyOverwriteFile(RunnerInfo runn
}

[TestMethod]
[TestCategory("Windows-Review")]
[NetFullTargetFrameworkDataSource]
public void TrxLoggerResultSummaryOutcomeValueShouldBeFailedIfNoTestsExecutedAndTreatNoTestsAsErrorIsTrue(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
{
Expand All @@ -169,7 +164,6 @@ public void TrxLoggerResultSummaryOutcomeValueShouldBeFailedIfNoTestsExecutedAnd
}

[TestMethod]
[TestCategory("Windows-Review")]
[NetFullTargetFrameworkDataSource]
public void TrxLoggerResultSummaryOutcomeValueShouldNotChangeIfNoTestsExecutedAndTreatNoTestsAsErrorIsFalse(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ namespace Microsoft.TestPlatform.AcceptanceTests;
public class MultitargetingTestHostTests : AcceptanceTestBase
{
[TestMethod]
[TestCategory("Windows-Review")]
// the underlying test is using xUnit to avoid AppDomain enhancements in MSTest that make this pass even without multitargetting
// xUnit supports net452 onwards, so that is why this starts at net452, I also don't test all framework versions
[NetCoreRunner(NETFX)]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,6 @@ public void EnvironmentVariablesSettingsShouldSetEnvironmentVariables(RunnerInfo
/// </summary>
/// <param name="runnerInfo"></param>
[TestMethod]
// patched dotnet is not published on non-windows systems
[TestCategory("Windows-Review")]
[NetFullTargetFrameworkDataSourceAttribute(useDesktopRunner: false)]
[NetCoreTargetFrameworkDataSourceAttribute(useDesktopRunner: false)]
public void RunSettingsAreLoadedFromProject(RunnerInfo runnerInfo)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ public class SerializationCompatibilityTests : AcceptanceTestBase
/// Verifies that discovery request/response messages serialize correctly across the version boundary.
/// </summary>
[TestMethod]
[TestCategory("Windows-Review")]
[RunnerCompatibilityDataSource()]
public void DiscoverTests_LatestRunner_WithOlderTesthosts(RunnerInfo runnerInfo)
{
Comment thread
nohwnd marked this conversation as resolved.
Expand Down Expand Up @@ -73,7 +72,6 @@ public void DiscoverTests_LatestRunner_WithOlderTesthosts(RunnerInfo runnerInfo)
/// Verifies that older runners can understand discovery responses from the new STJ-based testhost.
/// </summary>
[TestMethod]
[TestCategory("Windows-Review")]
[TestHostCompatibilityDataSource]
public void DiscoverTests_OlderRunners_WithLatestTesthost(RunnerInfo runnerInfo)
{
Comment thread
nohwnd marked this conversation as resolved.
Expand Down Expand Up @@ -109,7 +107,6 @@ public void DiscoverTests_OlderRunners_WithLatestTesthost(RunnerInfo runnerInfo)
/// Verifies that test run messages (start, result, complete) serialize correctly across versions.
/// </summary>
[TestMethod]
[TestCategory("Windows-Review")]
[RunnerCompatibilityDataSource]
public void RunTests_LatestRunner_WithOlderTesthosts(RunnerInfo runnerInfo)
{
Comment thread
nohwnd marked this conversation as resolved.
Expand Down Expand Up @@ -148,7 +145,6 @@ public void RunTests_LatestRunner_WithOlderTesthosts(RunnerInfo runnerInfo)
/// Verifies that older runners can process execution results from the new STJ-based testhost.
/// </summary>
[TestMethod]
[TestCategory("Windows-Review")]
[TestHostCompatibilityDataSource]
public void RunTests_OlderRunners_WithLatestTesthost(RunnerInfo runnerInfo)
{
Comment thread
nohwnd marked this conversation as resolved.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ public void TestCaseFilterShouldWorkIfOnlyPropertyValueGivenInExpression(RunnerI
/// Discover tests using mstest v1 adapter with test case filters.
/// </summary>
[TestMethod]
[TestCategory("Windows-Review")]
// MSTest v1 tests from dlls are only supported in .NET Framework runner, in and outside of VS
// via Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.dll
[NetFullTargetFrameworkDataSource(useCoreRunner: false)]
Comment thread
nohwnd marked this conversation as resolved.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ public void Cleanup()
}

[TestMethod]
[TestCategory("Windows-Review")]
[WrapperCompatibilityDataSource()]
public void RunTestsWithCustomTestHostLauncherAttachesToDebuggerUsingTheProvidedLauncher(RunnerInfo runnerInfo)
{
Comment thread
nohwnd marked this conversation as resolved.
Expand All @@ -57,7 +56,6 @@ public void RunTestsWithCustomTestHostLauncherAttachesToDebuggerUsingTheProvided
}

[TestMethod]
[TestCategory("Windows-Review")]
[TestCategory("Feature")]
[WrapperCompatibilityDataSource]
public void RunAllTestsWithMixedTFMsWillProvideAdditionalInformationToTheDebugger(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
namespace Microsoft.TestPlatform.Library.IntegrationTests.TranslationLayerTests;

[TestClass]
[TestCategory("Windows-Review")]
public class DataCollectorAttachmentProcessor : AcceptanceTestBase
{
Comment thread
nohwnd marked this conversation as resolved.
private readonly IVsTestConsoleWrapper _vstestConsoleWrapper;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ public void RunTestsWithNunitAdapter(RunnerInfo runnerInfo)
}

[TestMethod]
// there are logs in the diagnostic log, it is failing with NullReferenceException because path is null
[TestCategory("Windows-Review")]
[NetCoreTargetFrameworkDataSource]
public void RunTestsWithXunitAdapter(RunnerInfo runnerInfo)
{
Expand Down Expand Up @@ -104,7 +102,6 @@ public void RunTestsWithXunitAdapter(RunnerInfo runnerInfo)
}

[TestMethod]
[TestCategory("Windows-Review")]
// TODO: this does not work with netcore testhost, why?
[NetFullTargetFrameworkDataSource]
public void RunTestsWithNonDllAdapter(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ public void Cleanup()
}

[TestMethod]
[TestCategory("Windows-Review")]
[WrapperCompatibilityDataSource]
public void DiscoverTestsUsingDiscoveryEventHandler1(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
{
Expand All @@ -62,7 +61,6 @@ public void DiscoverTestsUsingDiscoveryEventHandler1(RunnerInfo runnerInfo)
}

[TestMethod]
[TestCategory("Windows-Review")]
[WrapperCompatibilityDataSource]
public void DiscoverTestsUsingDiscoveryEventHandler2AndTelemetryOptedOut(RunnerInfo runnerInfo)
{
Comment thread
nohwnd marked this conversation as resolved.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ public void Cleanup()
}

[TestMethod]
[TestCategory("Windows-Review")]
[WrapperCompatibilityDataSource]
public void RunAllTests(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
{
Expand Down Expand Up @@ -83,7 +82,6 @@ public void RunAllTestsFromDlls(RunnerInfo runnerInfo)
}

[TestMethod]
[TestCategory("Windows-Review")]
[WrapperCompatibilityDataSource()]
public void RunAllTestsWithMixedTFMsWillRunTestsFromAllProvidedDllEvenWhenTheyMixTFMs(RunnerInfo runnerInfo)
{
Comment thread
nohwnd marked this conversation as resolved.
Expand Down Expand Up @@ -195,7 +193,6 @@ public void RunTestsShouldThrowOnStackOverflowException(RunnerInfo runnerInfo)
}

[TestMethod]
[TestCategory("Windows-Review")]
[NetFullTargetFrameworkDataSource(useDesktopRunner: false)]
[NetCoreTargetFrameworkDataSource(useDesktopRunner: false)]
public void RunTestsShouldShowProperWarningOnNoTestsForTestCaseFilter(RunnerInfo runnerInfo)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ public void Cleanup()
}

[TestMethod]
[TestCategory("Windows-Review")]
[WrapperCompatibilityDataSource]
public void RunTestsWithTestCaseFilter(RunnerInfo runnerInfo)
Comment thread
nohwnd marked this conversation as resolved.
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ namespace Microsoft.TestPlatform.Library.IntegrationTests.TranslationLayerTests;

[TestClass]
// TODO: this comment seems inaccurate and would mean all our linux and macos tests are broken?
Comment thread
nohwnd marked this conversation as resolved.
// We need to dogfood the package built in this repo *-dev and we pack tha tp only on windows
[TestCategory("Windows-Review")]
public class SerialTestRunDecoratorTests : AcceptanceTestBase
{
private IVsTestConsoleWrapper? _vstestConsoleWrapper;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
namespace Microsoft.TestPlatform.Library.IntegrationTests.TranslationLayerTests;

[TestClass]
// We need to dogfood the package built in this repo *-dev and we pack tha tp only on windows
[TestCategory("Windows-Review")]
public class TargetFrameworkTestHostDemultiplexer : AcceptanceTestBase
{
private IVsTestConsoleWrapper? _vstestConsoleWrapper;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
namespace vstest.console.UnitTests.Processors;

[TestClass]
[TestCategory("Windows-Review")]
public class AeDebuggerArgumentProcessorTest
{
private readonly Mock<IEnvironment> _environment = new();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,6 @@ public void InitializeShouldCreateEntryForBlameAlongWithCollectHangDumpParameter
}

[TestMethod]
[TestCategory("Windows-Review")]
public void InitializeMonitorPostmortemDebuggerShouldGenerateCorrectConfiguration()
{
var runsettingsString = string.Format(CultureInfo.CurrentCulture, _defaultRunSettings, "");
Expand Down Expand Up @@ -434,7 +433,6 @@ public void InitializeMonitorPostmortemDebuggerShouldGenerateCorrectConfiguratio
}

[TestMethod]
[TestCategory("Windows-Review")]
public void InitializeMonitorPostmortemDebuggerShouldGenerateCorrectConfigurationAlsoIfIncomplete()
{
var runsettingsString = string.Format(CultureInfo.CurrentCulture, _defaultRunSettings, "");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
namespace vstest.console.UnitTests.Processors;

[TestClass]
[TestCategory("Windows-Review")]
public class ShowDeprecateDotnetVStestMessageArgumentProcessorTests
{
[TestMethod]
Expand Down
Loading