Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions src/Microsoft.TestPlatform.Client/Execution/TestRunRequest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
using Microsoft.VisualStudio.TestPlatform.Common.ExtensionFramework;
using Microsoft.VisualStudio.TestPlatform.Common.ExtensionFramework.Utilities;
using Microsoft.VisualStudio.TestPlatform.Common.Telemetry;
using Microsoft.VisualStudio.TestPlatform.Common.Utilities;
using Microsoft.VisualStudio.TestPlatform.CommunicationUtilities;
using Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.Interfaces;
using Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.ObjectModel;
Expand Down Expand Up @@ -441,42 +440,6 @@ public void HandleTestRunComplete(TestRunCompleteEventArgs runCompleteArgs, Test
// Fill in the time taken to complete the run
_requestData.MetricsCollection.Add(TelemetryDataConstants.TimeTakenInSecForRun, executionTotalTimeTaken.TotalSeconds);

// Record assemblies that vstest provided from its search directories.
// Telemetry gets 2 properties: assemblies resolved for user code (count only,
// no user assembly names), and assemblies resolved for Microsoft/System code (names ok).
var (userAssemblies, userCount, msAssemblies, msCount) = AssemblyResolver.GetProvidedDependencySummary();
if (userCount > 0)
{
_requestData.MetricsCollection.Add(TelemetryDataConstants.ProvidedDependenciesForUser, userAssemblies);
_requestData.MetricsCollection.Add(TelemetryDataConstants.ProvidedDependenciesForUserCount, userCount);
}
if (msCount > 0)
{
_requestData.MetricsCollection.Add(TelemetryDataConstants.ProvidedDependenciesForMicrosoft, msAssemblies);
_requestData.MetricsCollection.Add(TelemetryDataConstants.ProvidedDependenciesForMicrosoftCount, msCount);
}

// Opt-in warning: show all provided assemblies in summary when feature flag is set.
// Disable flag takes precedence over opt-in.
if ((userCount > 0 || msCount > 0)
&& !FeatureFlag.Instance.IsSet(FeatureFlag.VSTEST_DISABLE_WARN_MISSING_EXTENSIONS_DEPENDENCIES)
&& FeatureFlag.Instance.IsSet(FeatureFlag.VSTEST_OPTIN_WARN_MISSING_EXTENSIONS_DEPENDENCIES))
{
var allAssemblies = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
foreach (var kvp in AssemblyResolver.GetProvidedDependencies())
{
allAssemblies.Add(kvp.Key);
}

var message = string.Format(
CultureInfo.CurrentCulture,
ClientResources.ProvidedDependenciesWarning,
string.Join(", ", allAssemblies));

LoggerManager.HandleTestRunMessage(
new TestRunMessageEventArgs(TestMessageLevel.Warning, message));
}

// Fill in the Metrics From Test Host Process
var metrics = runCompleteArgs.Metrics;
if (metrics != null && metrics.Count != 0)
Expand Down
11 changes: 0 additions & 11 deletions src/Microsoft.TestPlatform.Client/Resources/Resources.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions src/Microsoft.TestPlatform.Client/Resources/Resources.resx
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,4 @@
<data name="WaitForCompletionOperationIsNotAllowedWhenNoTestRunIsActive" xml:space="preserve">
<value>Wait for completion operation is not allowed when there is no active test run. </value>
</data>
<data name="ProvidedDependenciesWarning" xml:space="preserve">
<value>The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</value>
</data>
</root>
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
<file datatype="xml" source-language="en" original="../Resources.resx" target-language="cs">
<body>
Expand All @@ -7,11 +7,6 @@
<target state="translated">Testovací běh nešlo spustit, protože byl neplatný počáteční stav.</target>
<note />
</trans-unit>
<trans-unit id="ProvidedDependenciesWarning">
<source>The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</source>
<target state="new">The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</target>
<note />
</trans-unit>
<trans-unit id="WaitForCompletionOperationIsNotAllowedWhenNoTestRunIsActive">
<source>Wait for completion operation is not allowed when there is no active test run. </source>
<target state="translated">V případě, že nejsou aktivní žádné testovací běhy, se operace čekání na dokončení nepovoluje. </target>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
<file datatype="xml" source-language="en" original="../Resources.resx" target-language="de">
<body>
Expand All @@ -7,11 +7,6 @@
<target state="translated">Der Testlauf konnte nicht ausgeführt werden, weil der Anfangszustand ungültig war.</target>
<note />
</trans-unit>
<trans-unit id="ProvidedDependenciesWarning">
<source>The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</source>
<target state="new">The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</target>
<note />
</trans-unit>
<trans-unit id="WaitForCompletionOperationIsNotAllowedWhenNoTestRunIsActive">
<source>Wait for completion operation is not allowed when there is no active test run. </source>
<target state="translated">Das Warten auf den Fertigstellungsvorgang ist unzulässig, wenn kein aktiver Testlauf vorhanden ist. </target>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
<file datatype="xml" source-language="en" original="../Resources.resx" target-language="es">
<body>
Expand All @@ -7,11 +7,6 @@
<target state="translated">No se pudo ejecutar la serie de pruebas porque el estado inicial no era válido.</target>
<note />
</trans-unit>
<trans-unit id="ProvidedDependenciesWarning">
<source>The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</source>
<target state="new">The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</target>
<note />
</trans-unit>
<trans-unit id="WaitForCompletionOperationIsNotAllowedWhenNoTestRunIsActive">
<source>Wait for completion operation is not allowed when there is no active test run. </source>
<target state="translated">La operación “Esperar que termine” no se permite cuando no hay ninguna serie de pruebas activa. </target>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
<file datatype="xml" source-language="en" original="../Resources.resx" target-language="fr">
<body>
Expand All @@ -7,11 +7,6 @@
<target state="translated">Impossible d'exécuter la série de tests, car l'état initial est non valide.</target>
<note />
</trans-unit>
<trans-unit id="ProvidedDependenciesWarning">
<source>The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</source>
<target state="new">The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</target>
<note />
</trans-unit>
<trans-unit id="WaitForCompletionOperationIsNotAllowedWhenNoTestRunIsActive">
<source>Wait for completion operation is not allowed when there is no active test run. </source>
<target state="translated">L'attente de la fin de l'exécution d'une opération n'est pas autorisée quand il n'existe aucune série de tests active. </target>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
<file datatype="xml" source-language="en" original="../Resources.resx" target-language="it">
<body>
Expand All @@ -7,11 +7,6 @@
<target state="translated">Non è stato possibile completare l'esecuzione dei test perché lo stato iniziale non era valido.</target>
<note />
</trans-unit>
<trans-unit id="ProvidedDependenciesWarning">
<source>The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</source>
<target state="new">The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</target>
<note />
</trans-unit>
<trans-unit id="WaitForCompletionOperationIsNotAllowedWhenNoTestRunIsActive">
<source>Wait for completion operation is not allowed when there is no active test run. </source>
<target state="translated">L'operazione di attesa completamento non è consentita se non sono presenti esecuzioni dei test attive. </target>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
<file datatype="xml" source-language="en" original="../Resources.resx" target-language="ja">
<body>
Expand All @@ -7,11 +7,6 @@
<target state="translated">初期状態が無効なため、テストの実行を実行できませんでした。</target>
<note />
</trans-unit>
<trans-unit id="ProvidedDependenciesWarning">
<source>The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</source>
<target state="new">The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</target>
<note />
</trans-unit>
<trans-unit id="WaitForCompletionOperationIsNotAllowedWhenNoTestRunIsActive">
<source>Wait for completion operation is not allowed when there is no active test run. </source>
<target state="translated">アクティブなテストの実行がない場合、完了の待機操作は許可されません。</target>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
<file datatype="xml" source-language="en" original="../Resources.resx" target-language="ko">
<body>
Expand All @@ -7,11 +7,6 @@
<target state="translated">초기 상태가 잘못되어 테스트 실행을 실행할 수 없습니다.</target>
<note />
</trans-unit>
<trans-unit id="ProvidedDependenciesWarning">
<source>The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</source>
<target state="new">The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</target>
<note />
</trans-unit>
<trans-unit id="WaitForCompletionOperationIsNotAllowedWhenNoTestRunIsActive">
<source>Wait for completion operation is not allowed when there is no active test run. </source>
<target state="translated">활성 테스트 실행이 없으면 완료 작업을 대기할 수 없습니다. </target>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
<file datatype="xml" source-language="en" original="../Resources.resx" target-language="pl">
<body>
Expand All @@ -7,11 +7,6 @@
<target state="translated">Nie można wykonać przebiegu testu, ponieważ stan początkowy jest nieprawidłowy.</target>
<note />
</trans-unit>
<trans-unit id="ProvidedDependenciesWarning">
<source>The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</source>
<target state="new">The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</target>
<note />
</trans-unit>
<trans-unit id="WaitForCompletionOperationIsNotAllowedWhenNoTestRunIsActive">
<source>Wait for completion operation is not allowed when there is no active test run. </source>
<target state="translated">Oczekiwanie na operację zakończenia nie jest dozwolone, gdy nie ma aktywnego przebiegu testu. </target>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
<file datatype="xml" source-language="en" original="../Resources.resx" target-language="pt-BR">
<body>
Expand All @@ -7,11 +7,6 @@
<target state="translated">A execução de teste não pôde ser realizada porque o estado inicial era inválido.</target>
<note />
</trans-unit>
<trans-unit id="ProvidedDependenciesWarning">
<source>The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</source>
<target state="new">The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</target>
<note />
</trans-unit>
<trans-unit id="WaitForCompletionOperationIsNotAllowedWhenNoTestRunIsActive">
<source>Wait for completion operation is not allowed when there is no active test run. </source>
<target state="translated">A operação esperar conclusão não é permitida quando não há nenhuma execução de teste ativa. </target>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
<file datatype="xml" source-language="en" original="../Resources.resx" target-language="ru">
<body>
Expand All @@ -7,11 +7,6 @@
<target state="translated">Не удалось выполнить тестовый запуск из-за недопустимого начального состояния.</target>
<note />
</trans-unit>
<trans-unit id="ProvidedDependenciesWarning">
<source>The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</source>
<target state="new">The test platform provided the following assemblies to resolve dependencies of test extensions that did not ship their own copy: {0}. Test extensions should ship all their dependencies.</target>
<note />
</trans-unit>
<trans-unit id="WaitForCompletionOperationIsNotAllowedWhenNoTestRunIsActive">
<source>Wait for completion operation is not allowed when there is no active test run. </source>
<target state="translated">Операция "Ожидать завершения" запрещена, если нет активного тестового запуска.</target>
Expand Down
Loading