Skip to content

Create source-only filter package#15638

Merged
Youssef1313 merged 31 commits into
mainfrom
dev/ygerges/filter-source-pkg
Apr 13, 2026
Merged

Create source-only filter package#15638
Youssef1313 merged 31 commits into
mainfrom
dev/ygerges/filter-source-pkg

Conversation

@Youssef1313

@Youssef1313 Youssef1313 commented Apr 7, 2026

Copy link
Copy Markdown
Member

Fixes #15361

Copilot AI review requested due to automatic review settings April 7, 2026 21:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI review requested due to automatic review settings April 8, 2026 07:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

…m.Filter.Source.csproj

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 8, 2026 07:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings April 8, 2026 08:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings April 8, 2026 09:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings April 8, 2026 10:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Copilot AI review requested due to automatic review settings April 8, 2026 10:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

@Youssef1313

Copy link
Copy Markdown
Member Author

@copilot Create a new test project for the new package.

You MUST:

  • Open a separate PR for that. Do not push to this PR.
  • The new test project shouldn't reference the csproj. Instead, it should manually add the C# source files to Compile item.
  • Write basic tests to validate the behavior of the APIs.

Copilot AI commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

@Youssef1313 I've opened a new pull request, #15641, to work on those changes. Once the pull request is ready, I'll request review from you.

@Youssef1313

Copy link
Copy Markdown
Member Author

@nohwnd Would you like to change all namespaces in the source-only package?

@Youssef1313

Copy link
Copy Markdown
Member Author

@copilot Please review this PR and add a comment with your findings. During review, ensure that all classes in the new package are internal and have embedded attribute (except when under #if IS_VSTEST_REPO).

This was referenced Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Ship source-only package with VSTest filter implementation

7 participants