Fix thread safety issues#15512
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several data structures shared across concurrent test execution threads were not thread-safe, risking corrupted results and lost updates.
Changes
TryGetValue+ set pattern withConcurrentDictionary.AddOrUpdatein metrics aggregation to eliminate lost-update racesList<Task>withConcurrentBag<Task>for_attachmentTasks; replaceContainsKey+TryAddTOCTOU pattern withGetOrAddfor bothAttachmentSetsand_attachmentTasksList<Guid>/Dictionary<Guid, BlameTestObject>withConcurrentQueue/ConcurrentDictionary; useInterlocked.Incrementfor_testEndCount; snapshot collections before passing toWriteTestSequenceInterlocked.Incrementfor all test counters (TotalTestCount,PassedTestCount,FailedTestCount,SkippedTests) to prevent lost updates under concurrent result arrival