Skip to content

Object Model Api fix #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
singhsarab merged 2 commits into from
Oct 26, 2017
Merged

Object Model Api fix #1231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a259e16
Adding the missing property LocalExtensionData in TestCase
singhsarab Oct 26, 2017
4aaf298
Fixed the test.
singhsarab Oct 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/Microsoft.TestPlatform.ObjectModel/TestCase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,12 @@ namespace Microsoft.VisualStudio.TestPlatform.ObjectModel
[DataContract]
public sealed class TestCase : TestObject
{
#if TODO
/// <summary>
/// LocalExtensionData which can be used by Adapter developers for local transfer of extended properties.
/// Note that this data is available only for in-Proc execution, and may not be available for OutProc executors
/// </summary>
private Object m_localExtensionData;
#endif
private Object localExtensionData;

private Guid defaultId = Guid.Empty;
private Guid id;
private string displayName;
Expand Down Expand Up @@ -70,17 +69,15 @@ public TestCase(string fullyQualifiedName, Uri executorUri, string source)

#region Properties

#if TODO
/// <summary>
/// LocalExtensionData which can be used by Adapter developers for local transfer of extended properties.
/// Note that this data is available only for in-Proc execution, and may not be available for OutProc executors
/// </summary>
public Object LocalExtensionData
{
get { return m_localExtensionData; }
set { m_localExtensionData = value; }
get { return localExtensionData; }
set { localExtensionData = value; }
}
#endif

/// <summary>
/// Gets or sets the id of the test case.
Expand Down
8 changes: 8 additions & 0 deletions test/Microsoft.TestPlatform.ObjectModel.UnitTests/TestCaseTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,14 @@ public void TestCaseIdShouldReturnIdSetExplicitlyEvenIfNameOrSourceInfoChanges()
Assert.AreEqual(testGuid, testCase.Id);
}

[TestMethod]
public void TestCaseLocalExtensionDataIsPubliclySettableGettableProperty()
{
var dummyData = "foo";
this.testCase.LocalExtensionData = dummyData;
Assert.AreEqual("foo", this.testCase.LocalExtensionData);
}

#region GetSetPropertyValue Tests

[TestMethod]
Expand Down