Do not crash data collector if a extension initialize fails. #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshjain2
approved these changes
Oct 26, 2017
sudiptadmsft
approved these changes
Oct 26, 2017
codito
added a commit
to codito/vstest
that referenced
this pull request
Oct 27, 2017
…ft#1230) * Do not crash data collector if a extension initialize fails. * Add unit tests for the scenario.
Merged
smadala
pushed a commit
that referenced
this pull request
Oct 30, 2017
* Object Model Api fix (#1231) * Adding the missing property LocalExtensionData in TestCase * Fixed the test. * Do not crash data collector if a extension initialize fails. (#1230) * Do not crash data collector if a extension initialize fails. * Add unit tests for the scenario. * Fix for changes in XPathNavigator for netcoreapp2.0 (#1226) * Fix for changes in XPathNavigator in netcoreapp2.0 * Removed IXPathNavigable. * Use TPv2 as default for .NET 3.5. (#1232) * Loading native dll's correctly for UWP release mode (#1234) * Loading native dll's correctly for UWP release mode * nit's * decouple process bitness with OS Architecture * HardCoded version of CLI to 2.1.0-preview1-007372 (#1238) HardCoded version of CLI to 2.1.0-preview1-007372 as the latest version has some issues. Reverted to old version of CLI because of dotnet/cli#7921 * Added null check for parent node. * Added conditional statements to support building against netcoreapp1.0 * Get OSArchitecture from Platform Abstraction to check for ARM Processor (#1242) * GetOsArchitecture from Platform Abstraction to check for ARM * making sure path is always small
smadala
pushed a commit
to smadala/vstest
that referenced
this pull request
Oct 31, 2017
…ft#1230) * Do not crash data collector if a extension initialize fails. * Add unit tests for the scenario.
Merged
smadala
added a commit
that referenced
this pull request
Oct 31, 2017
* Object Model Api fix (#1231) * Adding the missing property LocalExtensionData in TestCase * Fixed the test. * Do not crash data collector if a extension initialize fails. (#1230) * Do not crash data collector if a extension initialize fails. * Add unit tests for the scenario. * Use TPv2 as default for .NET 3.5. (#1232) * Loading native dll's correctly for UWP release mode (#1234) * Loading native dll's correctly for UWP release mode * nit's * decouple process bitness with OS Architecture * HardCoded version of CLI to 2.1.0-preview1-007372 (#1238) HardCoded version of CLI to 2.1.0-preview1-007372 as the latest version has some issues. Reverted to old version of CLI because of dotnet/cli#7921 * Get OSArchitecture from Platform Abstraction to check for ARM Processor (#1242) * GetOsArchitecture from Platform Abstraction to check for ARM * making sure path is always small
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In VS Professional SKU, code coverage data collector is not available. Initialize fails and data collector used to crash. This aborts the run with error. With this fix, the error will be logged for user, however test run will continue and results will be displayed.
Issue: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/VS.in%20Agile%20Testing%20IDE/_workitems/edit/513913