This repository was archived by the owner on Dec 5, 2022. It is now read-only.
Add RFC spec for Hierarchy property #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
shyamnamboodiripad
approved these changes
Jul 15, 2022
Member
Author
|
@shyamnamboodiripad Clarified some things based on your feedback. @nohwnd @Haplois Can you review this and merge it if it looks good? |
4 tasks
nohwnd
reviewed
Jul 19, 2022
7 tasks
nohwnd
approved these changes
Jul 19, 2022
Member
nohwnd
left a comment
nohwnd
left a comment
There was a problem hiding this comment.
Approving, because I am promised we can iterate on the design. And hopefully make the values separate properties that will be output only when they have non-default values. And same for the FQN properties, because keeping them custom (in property bag) adds a lot of overhead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.