Introduce a move command for the editor #9292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandy081
added
api
VIM
| @@ -1126,6 +1128,10 @@ export class Cursor extends EventEmitter { | |||
| return this._invokeForAll(ctx, (cursorIndex: number, oneCursor: OneCursor, oneCtx: IOneCursorOperationContext) => OneCursorOp.moveTo(oneCursor, inSelectionMode, ctx.eventData.position, ctx.eventData.viewPosition, ctx.eventSource, oneCtx)); | |||
| } | |||
|
|
|||
| private _move(inSelectionMode:boolean, ctx: IMultipleCursorOperationContext): boolean { | |||
There was a problem hiding this comment.
inSelectionMode should be added as a boolean argument accepted by the command. Not sure what name would be best.
There was a problem hiding this comment.
I would go for the same name 'inSelectionMode'.
|
@sandy081 I've reviewed |
|
@alexandrudima Thanks for the review. Incorporated the review feedback. Take a look. Thanks, |
|
@sandy081 LGTM |
|
Thanks @alexandrudima. Merging the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #9143
Introduce a move command for placing cursor at a logical view position in the editor.
Usage:
cursorMove{to: $viewPosition}Allowed view positions:
lineStart: Places the cursor at the start of the current line in the view.lineFirstNonWhitespaceCharacter: Places the cursor at the first non white space character of the current line in the view.lineEnd: Places the cursor at the end of the current line in the view.lineLastNonWhitespaceCharacter: Places the cursor at the last non white space character of the current line in the view.lineCenter: Places the cursor at the center of the line in the view.