Fixes #7500: Only update CSS if needed #8820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrmarti, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Tyriar and @kisstkondoros to be potential reviewers |
|
Hi @chrmarti, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| @@ -167,7 +168,14 @@ export class TerminalPanel extends Panel { | |||
| if (!themeId) { | |||
| themeId = this.themeService.getTheme(); | |||
| } | |||
| let theme = this.configurationHelper.getTheme(themeId); | |||
|
|
|||
| let terminalThemeId = this.configurationHelper.getTerminalThemeId(themeId); | |||
There was a problem hiding this comment.
Can you pull getBaseThemeId into this file and check it here instead of calling into configurationHelper twice?
chrmarti
force-pushed
the
chrmarti/lazycss
branch
from
77fa9fe to
32afeb3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.