Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list service of TreeView mishandled in block for FileExplorer #87805

Merged
merged 1 commit into from
Dec 30, 2019

Conversation

Vigilans
Copy link
Member

@Vigilans Vigilans commented Dec 28, 2019

This PR fixes #87804.

Though getMultiSelectedResources will be deprecated as described in #86268, this PR may add some cases for not breaking current behaviors when it gets removed.

There's a further scenario where getMultiSelectedResources will return a wrong resource:

  1. An extension adds a command to ExplorerItem's right click context.
  2. The command handler invokes revealFileInOS, but providing a uri different from selected file
  3. getMultiSelectedResources will still return selected file's uri, not the uri desired by the extension.

But this scenario seems so rare, so not included in this PR, just for a testcase when removing getMultiSelectedResources.

@isidorn
Copy link
Contributor

isidorn commented Dec 30, 2019

Thank you very much for this PR. It looks good to me, merging it in.
Sorry for breaking your extension! I was not aware that extension trees depend on the reveal in OS command.

@isidorn isidorn merged commit 2e881b9 into microsoft:master Dec 30, 2019
@isidorn isidorn added this to the January 2020 milestone Dec 30, 2019
@Vigilans Vigilans deleted the vigilans/get-selected-resource branch December 30, 2019 11:07
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execute revealFileInOS on TreeItem will use current focused file's URI
2 participants