Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to the contextmenu #83984

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Tweaks to the contextmenu #83984

merged 2 commits into from
Nov 5, 2019

Conversation

alexdima
Copy link
Member

@alexdima alexdima commented Nov 5, 2019

@jrieken

  • add Go to Implementation
  • add Go to References
  • remove "Peek" commands
  • move Find All References to its own group
Before After
image image

- add Go To Implementation
- remove "Peek" commands
@jrieken jrieken added this to the November 2019 milestone Nov 5, 2019
@jrieken
Copy link
Member

jrieken commented Nov 5, 2019

This left to be done:

  • extends the editor.gotoLocation.multiple-setting (Polish existing code navigation gestures #83752) so that it can be configured per navigation feature
  • change the group in the references-view-extensions (mock'ed in the screen shots)
  • (optionally) remove the peek command as they are subsumed by the setting above

@egamma
Copy link
Member

egamma commented Nov 5, 2019

A spelling nit... in the proposal it is:

  • go to definition -> singular, since the common case is that there is a single definition
  • go to references -> plural, since the common case is that there are many references

Assuming that multiple implementations is the common case, then it should be 'go to implementations' , or 'go to implementation(s)'

@jrieken jrieken merged commit 567ae20 into master Nov 5, 2019
@jrieken jrieken deleted the alex/contextmenu-proposal branch November 5, 2019 18:42
@jrieken
Copy link
Member

jrieken commented Nov 5, 2019

This is how it now looks. Note that in some language there might also be an additional "Go to Declaration" entry, e.g for C/CPP. There is now also a setting for each feature, e.g. editor.gotoLocation.multipleImplemenations which defines how it should behave in case multiple exist

Screenshot 2019-11-05 at 19 51 26

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants