Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cmd+F key in problems view robbed by find in editor #80068

Merged
merged 2 commits into from
Sep 2, 2019

Conversation

ypresto
Copy link
Contributor

@ypresto ypresto commented Aug 29, 2019

Cmd+F (Ctrl+F) in Problems View should focus filter, but actually it opens find widget in editor.
This PR increases weight of keybinding to fix it.
Also add focus filter keybinding in MarkerPanelFilterFocusContextKey to keep from focusing find widget (same approach as terminal.contribution.ts).

@sandy081
Copy link
Member

sandy081 commented Sep 2, 2019

Fixes issue #80207

@sandy081 sandy081 self-requested a review September 2, 2019 10:51
@sandy081 sandy081 added this to the September 2019 milestone Sep 2, 2019
Copy link
Member

@sandy081 sandy081 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandy081 sandy081 merged commit 43e6d83 into microsoft:master Sep 2, 2019
@ypresto ypresto deleted the fix-markers-key-weight branch September 2, 2019 18:00
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants