Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow goToLine to work backwards #79348

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Conversation

jmannanc
Copy link
Contributor

Fixes #79286

Are there any docs that would need editing too with a change like this?

@alexdima alexdima assigned bpasero and unassigned alexdima Aug 20, 2019
@bpasero bpasero added this to the On Deck milestone Aug 20, 2019
@bpasero bpasero modified the milestones: On Deck, September 2019 Aug 22, 2019
@bpasero bpasero self-requested a review August 25, 2019 07:49
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to still check for the line being valid though:

image

@jmannanc
Copy link
Contributor Author

Good catch! Just pushed a fix for it.

@bpasero bpasero merged commit c157da1 into microsoft:master Aug 26, 2019
@bpasero
Copy link
Member

bpasero commented Aug 26, 2019

Thanks 👍

@bpasero bpasero modified the milestones: September 2019, August 2019 Aug 26, 2019
@jmannanc
Copy link
Contributor Author

Thanks for merging, just wanted to reiterate my original question about the docs. Would there be anything I need to change or no?

@jmannanc jmannanc deleted the gotoline-negative branch August 26, 2019 10:53
@bpasero
Copy link
Member

bpasero commented Aug 26, 2019

Thanks for asking, I actually think we do not even document this feature on https://code.visualstudio.com/docs, but if you can find it we can update it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using -1 to go to the last line of a file.
5 participants