Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CompressibleObjectTree #77876

Merged
merged 23 commits into from
Sep 13, 2019
Merged

Introduce CompressibleObjectTree #77876

merged 23 commits into from
Sep 13, 2019

Conversation

joaomoreno
Copy link
Member

Details:

  • To facilitate adoption, it should be as similar to ObjectTree as possible with the following differences:
    • It demands renderers which know how to render compressed elements
    • It has an utility method to return the compression group an element might be in
  • It should have a enableCompression property which can be toggled at runtime
    • Note that focus/selection might change when this property is toggled
  • It is sightly more expensive than using the ObjectTree directly, since every element, even if uncompressed, is wrapped by a ICompressedTreeNode, so remember to recommend using the ObjectTree if compression isn't required

@joaomoreno joaomoreno added the tree-widget Tree widget issues label Jul 24, 2019
@joaomoreno joaomoreno added this to the July 2019 milestone Jul 24, 2019
@joaomoreno joaomoreno self-assigned this Jul 24, 2019
@joaomoreno joaomoreno changed the title Introduce CompressibleObjectTree Introduce CompressibleObjectTree Jul 24, 2019
@joaomoreno joaomoreno modified the milestones: July 2019, August 2019 Jul 26, 2019
@alexdima alexdima modified the milestones: August 2019, September 2019 Aug 27, 2019
@kieferrm kieferrm mentioned this pull request Sep 10, 2019
37 tasks
@joaomoreno joaomoreno merged commit 4f39995 into master Sep 13, 2019
@joaomoreno joaomoreno deleted the joao/compressed-trees branch September 13, 2019 07:04
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tree-widget Tree widget issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants