fix(sash): dragging being difficult with iframe-containing extensions #77121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that (running querySelector, getElementByTagName) that the contents of electron's `<webviews>`, which contain the iframe, are inaccessible. We were already disabling pointer events on iframes, this PR makes sure we do so on webviews as well.
Closed
|
@joaomoreno it looks like @mjbvz's fix is identical to this one, but has some additional code cleanup elsewhere. |
connor4312
commented
Jul 11, 2019
| @@ -280,7 +286,6 @@ export class Sash extends Disposable { | |||
|
|
|||
| dispose(disposables); | |||
|
|
|||
| const iframes = getElementsByTagName('iframe'); | |||
There was a problem hiding this comment.
I removed this so that we use the same set of frames we selected previously (iframes was shadowed here). No need to select them twice--even if there's new iframes/webviews that appeared whilst dragging, we don't need to 'reset' their pointer events since we didn't touch them before.
|
Thanks. The fix looks reasonable to me. It will be in the next 1.37 insiders build for testing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that (running querySelector, getElementByTagName) the
contents of electron's
<webviews>, which contain the iframe, areinaccessible. We were already disabling pointer events on iframes, this PR
makes sure we do so on webviews as well.
Fixes #76866