Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-72650 Shell paths should be validated before launched to prevent ambiguous errors - $Path check #76349

Merged
merged 3 commits into from
Jun 29, 2019

Conversation

skprabhanjan
Copy link
Contributor

@Tyriar , Here is the new PR to #72650.
Please let me know I can do something here and fix anything ( Maybe for the async part which I am anyways trying once ).
Thanks again :)

@Tyriar
Copy link
Member

Tyriar commented Jun 29, 2019

The failure to push thing was actually related to git lfs misbehaving in my setup.

@Tyriar Tyriar added this to the July 2019 milestone Jun 29, 2019
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes to make it all async again and base it on the tasks function (which tasks may depend on later #76351)

@Tyriar Tyriar merged commit 724b1c6 into microsoft:master Jun 29, 2019
@skprabhanjan
Copy link
Contributor Author

@Tyriar , Thanks a lot for the changes and merge :)
Will make sure to use better async approach from next time :)

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants