-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify dotnet build templates #76318
Modify dotnet build templates #76318
Conversation
Doesn't seem like the test failures are related to the change... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The full paths change looks good, but I'm not so sure about the NoSummary
change. People are pretty used to seeing an error summary at the end. I am not a heavy user of dotnet though. Can you add an additional comment about what that argument does so that users of the template can see why the summary is missing?
@alexr00 Since the errors are repeated in the summary, in the problems pane there are duplicate errors: If we disable the summary then there is only one error. Does that sound reasonable ? Is there any other way we can reduce the duplicate errors coming up in the problems pane ? |
@alexr00 Any updates here ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delay, I was on vacation.
Looks good thank you!
Hi @akshita31 , I couldn`t use dotnet build in VS 1.37.0 version. I shows the following issue. |
Fixes: dotnet/vscode-csharp#1198, dotnet/vscode-csharp#1197