Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify dotnet build templates #76318

Merged
merged 3 commits into from
Jul 29, 2019

Conversation

akshita31
Copy link
Contributor

  1. The build should produce fullpaths because that is needed by the msCompile problem matcher.
  2. The build should not produce summary as then in the "Problems" pane, the errors are duplicated.

Fixes: dotnet/vscode-csharp#1198, dotnet/vscode-csharp#1197

@akshita31
Copy link
Contributor Author

cc @rchande @gregg-miskelly

@rchande
Copy link

rchande commented Jul 1, 2019

Doesn't seem like the test failures are related to the change...

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full paths change looks good, but I'm not so sure about the NoSummary change. People are pretty used to seeing an error summary at the end. I am not a heavy user of dotnet though. Can you add an additional comment about what that argument does so that users of the template can see why the summary is missing?

@akshita31
Copy link
Contributor Author

@alexr00 Since the errors are repeated in the summary, in the problems pane there are duplicate errors:

image

If we disable the summary then there is only one error. Does that sound reasonable ? Is there any other way we can reduce the duplicate errors coming up in the problems pane ?

@akshita31
Copy link
Contributor Author

@alexr00 Any updates here ?

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay, I was on vacation.
Looks good thank you!

@alexr00 alexr00 merged commit 0a21b40 into microsoft:master Jul 29, 2019
@akshita31 akshita31 deleted the modify_build_templates_for_dotnet branch August 2, 2019 19:41
@Arunsanthoshh
Copy link

Arunsanthoshh commented Aug 14, 2019

Hi @akshita31 ,

I couldn`t use dotnet build in VS 1.37.0 version. I shows the following issue.
image

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors are duplicated in output window
6 participants