Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-73341 Installing extension from extension page "Install" button keeps the notification baloon in bottom right #74795

Merged
merged 3 commits into from
Jul 12, 2019
Merged

Fix-73341 Installing extension from extension page "Install" button keeps the notification baloon in bottom right #74795

merged 3 commits into from
Jul 12, 2019

Conversation

skprabhanjan
Copy link
Contributor

@sandy081 , Removed the notification bubble as discussed to fix #73341.
Please review this and let me know :)

@kieferrm kieferrm requested a review from sandy081 June 3, 2019 16:55
@sandy081 sandy081 added this to the May 2019 milestone Jun 3, 2019
@skprabhanjan
Copy link
Contributor Author

@sandy081 , Sorry for that , Did not check that part.
Changed it accordingly :)

@sandy081
Copy link
Member

sandy081 commented Jun 5, 2019

@skprabhanjan looks like your change has build failures. Can you please fix them.
I guess it is caused because of unused import Severity.

@dmolin
Copy link
Contributor

dmolin commented Jun 5, 2019 •
edited
Loading

@skprabhanjan looks like your change has build failures. Can you please fix them.
I guess it is caused because of unused import Severity.

@sandy081 , It's true on Linux/Mac, but on Windows it seems quite a different error, occurred when installing dependencies:

d:\a\1\s\remote\node_modules\keytar\node_modules\nan\nan.h(24): fatal error C1083: Cannot open include file: 'node_version.h': No such file or directory (compiling source file ..\src\async.cc) [D:\a\1\s\remote\node_modules\keytar\build\keytar.vcxproj]

@sandy081
Copy link
Member

sandy081 commented Jun 6, 2019

Could be a random error in windows.

@bpasero bpasero modified the milestones: May 2019, June 2019 Jun 7, 2019
@skprabhanjan
Copy link
Contributor Author

skprabhanjan commented Jun 10, 2019 •
edited
Loading

@sandy081 , I have removed the unused import

@skprabhanjan
Copy link
Contributor Author

@sandy081 , Any update on this PR ?
The build should be good now.

@skprabhanjan skprabhanjan mentioned this pull request Jun 25, 2019
Closed
@sandy081 sandy081 modified the milestones: June 2019, July 2019 Jun 25, 2019
@sandy081
Copy link
Member

Will take a look in next milestone.

@skprabhanjan
Copy link
Contributor Author

@sandy081 , this should be good to be merged now correct ? ( if the PR has passed your review)

@skprabhanjan
Copy link
Contributor Author

@sandy081 , any updates on this ? Sorry

@sandy081 sandy081 merged commit 2e53042 into microsoft:master Jul 12, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandy081 sandy081 sandy081 approved these changes

Assignees

@sandy081 sandy081

Labels
None yet
Projects
None yet
Milestone
July 2019
Development

Successfully merging this pull request may close these issues.

Installing extension from extension page "Install" button keeps the notification baloon in bottom right
4 participants
@skprabhanjan @sandy081 @dmolin @bpasero