-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't expand parent element if it's the root in single folder workspace when editing an element in explorer. #72627
Conversation
This trully fixes that issue. |
@isidorn Looking at this in more detail I found that the real problem is when disposing the input element because the renderElement method gets sometimes called more than once between |
This seems to be working except that it breaks when you are editing an element and click on the Refresh or Collapse All buttons, maybe they should be disabled like the New File and New Folder buttons. |
This is good work. Let's merge it in. I will remove the ignoreDisposeAndBlur and check the refresh action. Thanks a lot! |
Great! Don't forget about the |
|
@isidorn I just build and tested it from source code, is this expected? |
You are correct. I have tackled that via 0991cb5 |
Fixes #72626