-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration + UI to remember extensions allowed to handle URIs #70844
Merged
joaomoreno
merged 11 commits into
microsoft:master
from
dalongi:remember-uri-handler-confirmation
Jul 26, 2019
Merged
Configuration + UI to remember extensions allowed to handle URIs #70844
joaomoreno
merged 11 commits into
microsoft:master
from
dalongi:remember-uri-handler-confirmation
Jul 26, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
added
extensions
Issues concerning extensions
workbench-os-integration
Native OS integration issues
labels
Mar 25, 2019
@joaomoreno any updates on this? |
Merge upstream
Merge master
Merge upstream
Sorry for the delay... Thanks! 🍻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #69166.
What
Extensions that offer frequently-used URI handlers present a tedious UX: every time the URI handler is invoked, the user has to manually confirm that the extension is allowed to do it.
This change addresses the problem in two ways:
Manual Testing
General setup for testing URI handlers
Prompt behavior is not regressed
Valid configuration settings
Invalid configuration settings
Checkbox setting