SmartSelect fixes and tests #57012
Closed
SmartSelect fixes and tests #57012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@ris58h sorry for the delay. we are still interested in this PR, especially now that smart select is being revisited. Can you update your PR so that I can merge? Thanks |
|
Sorry, closing this as we plan to nuke the token-based provider all together. We have a first proposal for extension API so that language smarts can be used for good selection ranges. We are also working on better default providers for word, lines, bracket et al, see #64004 and the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are couple of changes and fixes which should improve Smart Select:
tokenTree.tsrefactoring.Node.parentis removed (it's useless and there was an issue with it anyway) andNodeListandBlockbehave like immutable now._doGetRangesToPositionchanged respectively and collects ranges top-to-bottom instead of bottom-to-top.Fix from Fix block selection #56807 PR.
Improvement of selection of adjacent blocks (I didn't make better name for it). It's when the ending of one block is on on the same line with the beginning of the another block.
Before:
After:
Tests!