Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting to center the layout when turning on the zen mode #44116

Merged
merged 1 commit into from
Feb 21, 2018

Conversation

SrTobi
Copy link
Contributor

@SrTobi SrTobi commented Feb 21, 2018

@isidorn as discussed in #40757 this PR adds a setting to centered the layout when activating the zenmode

@isidorn isidorn self-assigned this Feb 21, 2018
@isidorn isidorn added this to the February 2018 milestone Feb 21, 2018
@SrTobi
Copy link
Contributor Author

SrTobi commented Feb 21, 2018

I simply used the logic used with zenmode.fullScreen. Should work fine. Was not sure when naming the setting... could also be called zenmode.centerLayout.

@isidorn
Copy link
Contributor

isidorn commented Feb 21, 2018

@SrTobi works great. Code changes are good as well.
Awesome work, merging 🍻

@isidorn isidorn merged commit 32b28ce into microsoft:master Feb 21, 2018
@isidorn
Copy link
Contributor

isidorn commented Feb 21, 2018

@SrTobi yeah, centerLayout is better! I will change on master

@vraa
Copy link

vraa commented Feb 23, 2018

Any idea when this will be available to use?

@SrTobi SrTobi deleted the centered-zen branch February 24, 2018 09:52
@isidorn
Copy link
Contributor

isidorn commented Feb 26, 2018

@vraa this is available in vscode insiders. In vscode stable it will be availble in around 10 days.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants