Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML aria attribute autocomplete #363

Merged
merged 1 commit into from
Nov 21, 2015
Merged

Add HTML aria attribute autocomplete #363

merged 1 commit into from
Nov 21, 2015

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Nov 20, 2015

Fixes #320

/cc @aeschli

aria_autocomplete

@msftclas
Copy link

Hi @Tyriar, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@dstorey
Copy link
Member

dstorey commented Nov 20, 2015

Should this take into account the aria attributes are not really global? Some are only valid if the element is a particular role (either via role attribute or the element's natural semantics)

@Tyriar
Copy link
Member Author

Tyriar commented Nov 20, 2015

That's beyond the abilities of the code currently, the same applies to a set of elements only being valid within certain elements (ul, ol can only contain only contain li elements) which doesn't happen at the moment. That and adding descriptions to all the tags/attributes (#323) I think should follow this. I made another issue to that effect #375

@dstorey
Copy link
Member

dstorey commented Nov 20, 2015

Sounds good

aeschli added a commit that referenced this pull request Nov 21, 2015
Add HTML aria attribute autocomplete
@aeschli aeschli merged commit 47eb735 into microsoft:master Nov 21, 2015
@aeschli
Copy link
Contributor

aeschli commented Nov 21, 2015

Thanks @Tyriar, very nice pull request!

@Tyriar Tyriar deleted the 320_aria_attributes branch November 29, 2015 02:23
@zbandhan
Copy link

And also HTML role attribute should auto-complete.

@Tyriar
Copy link
Member Author

Tyriar commented Nov 30, 2015

@zbandhan that was added in 98f9564 and successive commits.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support HTML aria attribute completion
5 participants