Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #27408 - Adds ViewColumn.Active #34649

Merged
merged 1 commit into from
Sep 20, 2017

Conversation

eamodio
Copy link
Contributor

@eamodio eamodio commented Sep 19, 2017

This should close #27408, since we don't want to change the default -- there is now an explicit way for an extension to target the active view column.

Once this is in, the Git extension can be updated to use this re: #34459

FYI, I used -1 to help avoid any falsey issues.

/cc @jrieken @bpasero

@jrieken jrieken added api feature-request Request for new features or functionality labels Sep 20, 2017
@jrieken jrieken added this to the September 2017 milestone Sep 20, 2017
@jrieken
Copy link
Member

jrieken commented Sep 20, 2017

Very nice. Thanks @eamodio

@jrieken jrieken merged commit 7c0116c into microsoft:master Sep 20, 2017
@jrieken jrieken added on-testplan release-notes Release notes issues labels Sep 25, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api feature-request Request for new features or functionality on-testplan release-notes Release notes issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

showTextDocument & vscode.diff always default to ViewColumn.One
2 participants