sessions: Remove session metadata setting - #331928
Merged
Sandeep Somavarapu (sandy081) merged 1 commit intoAug 21, 2026
Merged
Conversation
Make the new session tabs and input metadata presentation unconditional, and remove the retired header/tab fallback paths and fixtures.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
August 21, 2026 09:39
Copilot started reviewing on behalf of
Sandeep Somavarapu (sandy081)
August 21, 2026 09:40
View session
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
Benjamin Christopher Simmonds (benibenj)
approved these changes
Aug 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the session-metadata placement setting and standardizes metadata pills above the chat input.
Changes:
- Removes configuration gates and obsolete header/tab metadata UI.
- Makes single-group chat tabs replace the header.
- Updates accessibility guidance, fixtures, and regression tests.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/test/browser/componentFixtures/sessions/viewAllChanges.fixture.ts |
Updates metadata pill host styling. |
src/vs/workbench/test/browser/componentFixtures/sessions/sessionHeader.fixture.ts |
Removes header metadata fixtures. |
src/vs/workbench/test/browser/componentFixtures/sessions/sessionChatInputToolbar.fixture.ts |
Updates completed-session fixture. |
src/vs/workbench/test/browser/componentFixtures/sessions/openPullRequest.fixture.ts |
Updates pull-request pill host. |
src/vs/workbench/test/browser/componentFixtures/sessions/openIssue.fixture.ts |
Updates issue pill host. |
src/vs/sessions/test/browser/sessionHeader.test.ts |
Verifies header metadata removal. |
src/vs/sessions/test/browser/chatCompositeBar.test.ts |
Verifies tab metadata removal. |
src/vs/sessions/contrib/github/browser/pullRequestActions.ts |
Updates metadata documentation. |
src/vs/sessions/contrib/github/browser/issueActions.ts |
Updates issue-pill documentation. |
src/vs/sessions/contrib/files/browser/workspaceFolderActions.ts |
Removes metadata configuration gate. |
src/vs/sessions/contrib/chat/test/browser/sessionChatInputToolbar.test.ts |
Removes obsolete placement test. |
src/vs/sessions/contrib/chat/browser/sessionsChatAccessibilityHelp.ts |
Documents final pill and tab behavior. |
src/vs/sessions/contrib/chat/browser/sessionMetadataPills.ts |
Makes metadata pills unconditional. |
src/vs/sessions/contrib/chat/browser/sessionChatInputToolbar.ts |
Combines metadata and status pills. |
src/vs/sessions/contrib/chat/browser/chat.contribution.ts |
Removes setting registration. |
src/vs/sessions/contrib/changes/browser/changesActions.ts |
Updates changes-pill documentation. |
src/vs/sessions/common/sessionConfig.ts |
Removes setting constant. |
src/vs/sessions/browser/parts/sessionView.ts |
Makes tabs replace single-group headers. |
src/vs/sessions/browser/parts/sessionHeader.ts |
Removes header metadata toolbar. |
src/vs/sessions/browser/parts/media/chatCompositeBar.css |
Removes obsolete metadata-row styles. |
src/vs/sessions/browser/parts/chatCompositeBar.ts |
Removes tab-strip metadata fallback. |
Review details
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 21/21 changed files
- Comments generated: 1
- Review effort level: Balanced
Contributor
Screenshot ChangesBase: Changed (36)
|
| Before | After |
|---|---|
 |
 |
sessions/sessionChatInputToolbar/SessionChatPills_ChangesSingleFile/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionChatInputToolbar/SessionChatPills_ChangesMultipleFiles/Dark
| Before | After |
|---|---|
 |
|
sessions/sessionChatInputToolbar/SessionChatPills_ChangesMultipleFiles/Light
| Before | After |
|---|---|
 |
|
sessions/sessionChatInputToolbar/SessionChatPills_ChangesOnlyInsertions/Dark
| Before | After |
|---|---|
 |
|
sessions/sessionChatInputToolbar/SessionChatPills_ChangesOnlyInsertions/Light
| Before | After |
|---|---|
 |
|
sessions/sessionChatInputToolbar/SessionChatPills_ChangesOnlyDeletions/Dark
| Before | After |
|---|---|
 |
|
sessions/sessionChatInputToolbar/SessionChatPills_ChangesOnlyDeletions/Light
| Before | After |
|---|---|
 |
|
sessions/sessionChatInputToolbar/SessionChatPills_ExternalMarkdownPreview/Dark
| Before | After |
|---|---|
 |
|
sessions/sessionChatInputToolbar/SessionChatPills_ExternalMarkdownPreview/Light
| Before | After |
|---|---|
 |
|
sessions/sessionChatInputToolbar/SessionChatPills_WorkspaceMarkdown_NoPreview/Dark
| Before | After |
|---|---|
 |
|
sessions/sessionChatInputToolbar/SessionChatPills_WorkspaceMarkdown_NoPreview/Light
| Before | After |
|---|---|
 |
|
sessions/sessionChatInputToolbar/SessionChatPills_ExternalMarkdownMultiple_PrimaryCreated/Dark
| Before | After |
|---|---|
 |
|
sessions/sessionChatInputToolbar/SessionChatPills_ExternalMarkdownMultiple_PrimaryCreated/Light
| Before | After |
|---|---|
 |
|
sessions/sessionChatInputToolbar/SessionChatPills_ExternalMarkdown_PrimaryEdited/Dark
| Before | After |
|---|---|
 |
|
sessions/sessionChatInputToolbar/SessionChatPills_ExternalMarkdown_PrimaryEdited/Light
| Before | After |
|---|---|
 |
|
sessions/sessionChatInputToolbar/SessionChatPills_BackgroundWithChanges/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionChatInputToolbar/SessionChatPills_BackgroundWithChanges/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionChatInputToolbar/SessionChatPills_DebugFakeData/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionChatInputToolbar/SessionChatPills_DebugFakeData/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionChatInputToolbar/SessionChatPills_HorizontalOverflow/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionChatInputToolbar/SessionChatPills_HorizontalOverflow/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionChatInputToolbar/SessionChatView_ChangesPill/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionChatInputToolbar/SessionChatView_ChangesPill/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionChatInputToolbar/SessionChatView_ChangesAndExternalPreview/Dark
| Before | After |
|---|---|
 |
|
sessions/sessionChatInputToolbar/SessionChatView_ChangesAndExternalPreview/Light
| Before | After |
|---|---|
 |
|
sessions/sessionChatInputToolbar/SessionChatView_ReadOnlyPills/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionChatInputToolbar/SessionChatView_ReadOnlyPills/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionHeader/SessionHeader_Default/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionHeader/SessionHeader_Default/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionHeader/SessionHeader_InProgress/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionHeader/SessionHeader_InProgress/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionHeader/SessionHeader_NeedsInput/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionHeader/SessionHeader_NeedsInput/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionHeader/SessionHeader_LongTitle/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionHeader/SessionHeader_LongTitle/Light
| Before | After |
|---|---|
 |
 |
Added (2)
sessions/sessionChatInputToolbar/SessionChatPills_CompletedSessionChanges/Dark
sessions/sessionChatInputToolbar/SessionChatPills_CompletedSessionChanges/Light
Removed (8)
sessions/sessionChatInputToolbar/SessionChatPills_MetadataPlacementReplacesTurnChanges/Dark
sessions/sessionChatInputToolbar/SessionChatPills_MetadataPlacementReplacesTurnChanges/Light
sessions/sessionHeader/SessionHeader_MetadataInInput/Dark
sessions/sessionHeader/SessionHeader_MetadataInInput/Light
sessions/sessionHeader/SessionHeader_NoWorkspace/Dark
sessions/sessionHeader/SessionHeader_NoWorkspace/Light
sessions/sessionHeader/SessionHeader_WithPullRequest/Dark
sessions/sessionHeader/SessionHeader_WithPullRequest/Light
Sandeep Somavarapu (sandy081)
deleted the
agents/remove-session-metadata-setting
branch
August 21, 2026 10:29
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chat.agentSessions.showSessionMetadataInInputand all configuration gatesValidation
npm run compilenpm run hygienenpm run typecheck-clientnpm run transpile-client./scripts/test.sh --run src/vs/sessions/test/browser/sessionView.test.ts --run src/vs/sessions/test/browser/sessionHeader.test.ts --run src/vs/sessions/test/browser/chatCompositeBar.test.ts --run src/vs/sessions/test/browser/chatGroupsView.test.ts --run src/vs/sessions/contrib/chat/test/browser/sessionChatInputToolbar.test.ts(27 passing)