Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loader.js - some few Utilities changement #322

Closed
wants to merge 5 commits into from
Closed

loader.js - some few Utilities changement #322

wants to merge 5 commits into from

Conversation

mr21
Copy link

@mr21 mr21 commented Nov 20, 2015

Hi :)

For my first easy commit I propose some little changement about the Utilities object of the loader.js file.

Is it okay?

@msftclas
Copy link

Hi @mr21, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@alexdima
Copy link
Member

@mr21 Very sorry about not communicating this properly, loader.js is a generated file from a TypeScript file that is not yet made public (a different repo). I need to create the public repo that contains it.

Will ping you as soon as I get that done.

@mr21
Copy link
Author

mr21 commented Nov 20, 2015

@alexandrudima oh okay, my bad..
So it's only concerne the *.ts files?

@alexdima
Copy link
Member

@mr21

I have updated the 4 .js files to have a good header indicating they should not be edited directly and released the TypeScript sources for them at https://github.com/Microsoft/vscode-loader .

Thank you very much for your interest and I am sorry these are generated resources and I cannot accept this pull request. Please make a pull request against the vscode-loader repository in the *.ts files.

Once again, please accept my apologies for not marking these files properly from the beginning.

Cheers,
Alex

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants