Skip to content

Revert "sessions - allow to open preview from markdown files" - #299392

Merged
Benjamin Pasero (bpasero) merged 1 commit into
mainfrom
revert-299047-ben/grateful-wolf
Mar 5, 2026
Merged

Revert "sessions - allow to open preview from markdown files"#299392
Benjamin Pasero (bpasero) merged 1 commit into
mainfrom
revert-299047-ben/grateful-wolf

Conversation

@bpasero

Copy link
Copy Markdown
Contributor

Reverts #299047

Copilot AI review requested due to automatic review settings March 5, 2026 06:59
@bpasero Benjamin Pasero (bpasero) added this to the 1.111.0 milestone Mar 5, 2026
@bpasero
Benjamin Pasero (bpasero) enabled auto-merge (squash) March 5, 2026 07:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts #299047, which had introduced a floating "Open Preview" button for markdown (and related language) files in the Agent Sessions window. The revert removes both the registration of the MenuId.EditorContent menu item and its associated contribution entry point.

Changes:

  • Removes the markdownPreview.contribution.ts file entirely.
  • Removes the corresponding import of that contribution from the sessions desktop entry point.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/vs/sessions/sessions.desktop.main.ts Removes the import of the markdown preview contribution
src/vs/sessions/contrib/markdownPreview/browser/markdownPreview.contribution.ts Deletes the contribution file that registered the "Open Preview" menu item

@bpasero
Benjamin Pasero (bpasero) merged commit a482aa0 into main Mar 5, 2026
24 checks passed
@bpasero
Benjamin Pasero (bpasero) deleted the revert-299047-ben/grateful-wolf branch March 5, 2026 07:13
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Apr 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants