Skip to content

dialogs: prevent custom dialogs from overflowing screen vertically #299048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Connor Peet (connor4312) merged 1 commit into from
Mar 3, 2026
Merged

dialogs: prevent custom dialogs from overflowing screen vertically #299048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/vs/base/browser/ui/dialog/dialog.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
width: min-content;
min-width: 500px;
max-width: 90vw;
max-height: 90vh;
min-height: 75px;
Comment thread
connor4312 marked this conversation as resolved.
padding: 10px;
Comment thread
connor4312 marked this conversation as resolved.
transform: translate3d(0px, 0px, 0px);
Expand Down Expand Up @@ -55,12 +56,18 @@
flex-grow: 1;
align-items: center;
padding: 0 10px;
min-height: 0; /* allow flex item to shrink below content size */
overflow: hidden;
}

.monaco-dialog-box.align-vertical .dialog-message-row {
flex-direction: column;
}

.monaco-dialog-box.align-vertical .dialog-message-row .dialog-message-container {
min-height: 0; /* allow flex item to shrink below content size in column layout */
}

.monaco-dialog-box .dialog-message-row > .dialog-icon.codicon {
flex: 0 0 48px;
height: 48px;
Expand All @@ -77,12 +84,17 @@
align-self: baseline;
}

.monaco-dialog-box:not(.align-vertical) .dialog-message-row .dialog-message-container {
align-self: stretch; /* fill row height so overflow-y scrolling works */
}

/** Dialog: Message/Footer Container */
.monaco-dialog-box .dialog-message-row .dialog-message-container,
.monaco-dialog-box .dialog-footer-row {
display: flex;
flex-direction: column;
overflow: hidden;
overflow-y: auto;
overflow-x: hidden;
text-overflow: ellipsis;
user-select: text;
-webkit-user-select: text;
Expand Down
Loading