Skip to content

sessions - context menu on title for session actions #298968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Benjamin Pasero (bpasero) merged 4 commits into from
Mar 3, 2026
Merged

sessions - context menu on title for session actions #298968

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
466b578
sessions - context menu on title for session actions
bpasero Mar 3, 2026
d280209
Update src/vs/sessions/contrib/sessions/browser/sessionsTitleBarWidge…
bpasero Mar 3, 2026
577afb1
ccr
bpasero Mar 3, 2026
84149ad
ccr
bpasero Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 55 additions & 3 deletions src/vs/sessions/contrib/sessions/browser/sessionsTitleBarWidget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,23 @@
*--------------------------------------------------------------------------------------------*/

import './media/sessionsTitleBarWidget.css';
import { $, addDisposableListener, EventType, reset } from '../../../../base/browser/dom.js';
import { $, addDisposableListener, EventType, getActiveWindow, reset } from '../../../../base/browser/dom.js';

import { Separator } from '../../../../base/common/actions.js';
import { Disposable, DisposableStore, MutableDisposable } from '../../../../base/common/lifecycle.js';
import { MarshalledId } from '../../../../base/common/marshallingIds.js';
import { StandardMouseEvent } from '../../../../base/browser/mouseEvent.js';
import { localize } from '../../../../nls.js';
import { IHoverService } from '../../../../platform/hover/browser/hover.js';
import { getDefaultHoverDelegate } from '../../../../base/browser/ui/hover/hoverDelegateFactory.js';
import { BaseActionViewItem, IBaseActionViewItemOptions } from '../../../../base/browser/ui/actionbar/actionViewItems.js';
import { IInstantiationService } from '../../../../platform/instantiation/common/instantiation.js';
import { MenuRegistry, SubmenuItemAction } from '../../../../platform/actions/common/actions.js';
import { ContextKeyExpr } from '../../../../platform/contextkey/common/contextkey.js';
import { IMenuService, MenuId, MenuRegistry, SubmenuItemAction } from '../../../../platform/actions/common/actions.js';
import { IContextKeyService, ContextKeyExpr } from '../../../../platform/contextkey/common/contextkey.js';
import { IContextMenuService } from '../../../../platform/contextview/browser/contextView.js';
import { ChatContextKeys } from '../../../../workbench/contrib/chat/common/actions/chatContextKeys.js';
import { IMarshalledAgentSessionContext } from '../../../../workbench/contrib/chat/browser/agentSessions/agentSessionsModel.js';
import { IChatSessionsService } from '../../../../workbench/contrib/chat/common/chatSessionsService.js';

import { Menus } from '../../../browser/menus.js';
import { IWorkbenchContribution } from '../../../../workbench/common/contributions.js';
Expand Down Expand Up @@ -65,6 +72,10 @@ export class SessionsTitleBarWidget extends BaseActionViewItem {
@ISessionsManagementService private readonly activeSessionService: ISessionsManagementService,
@IChatService private readonly chatService: IChatService,
@IAgentSessionsService private readonly agentSessionsService: IAgentSessionsService,
@IContextMenuService private readonly contextMenuService: IContextMenuService,
@IMenuService private readonly menuService: IMenuService,
@IContextKeyService private readonly contextKeyService: IContextKeyService,
@IChatSessionsService private readonly chatSessionsService: IChatSessionsService,
) {
super(undefined, action, options);

Expand Down Expand Up @@ -176,6 +187,11 @@ export class SessionsTitleBarWidget extends BaseActionViewItem {
e.stopPropagation();
this._showSessionsPicker();
}));
this._dynamicDisposables.add(addDisposableListener(sessionPill, EventType.CONTEXT_MENU, (e) => {
e.preventDefault();
e.stopPropagation();
this._showContextMenu(e);
}));

this._container.appendChild(sessionPill);

Expand Down Expand Up @@ -284,6 +300,42 @@ export class SessionsTitleBarWidget extends BaseActionViewItem {
return basename(uri);
}

private _showContextMenu(e: MouseEvent): void {
const activeSession = this.activeSessionService.getActiveSession();
if (!activeSession) {
return;
}

const agentSession = this.agentSessionsService.getSession(activeSession.resource);
if (!agentSession) {
return;
}

this.chatSessionsService.activateChatSessionItemProvider(agentSession.providerType);

const contextOverlay: Array<[string, boolean | string]> = [
[ChatContextKeys.isArchivedAgentSession.key, agentSession.isArchived()],
[ChatContextKeys.isReadAgentSession.key, agentSession.isRead()],
[ChatContextKeys.agentSessionType.key, agentSession.providerType],
];

const menu = this.menuService.createMenu(MenuId.AgentSessionsContext, this.contextKeyService.createOverlay(contextOverlay));

const marshalledContext: IMarshalledAgentSessionContext = {
session: agentSession,
sessions: [agentSession],
$mid: MarshalledId.AgentSessionContext,
};

this.contextMenuService.showContextMenu({
getActions: () => Separator.join(...menu.getActions({ arg: marshalledContext, shouldForwardArgs: true }).map(([, actions]) => actions)),
getAnchor: () => new StandardMouseEvent(getActiveWindow(), e),
getActionsContext: () => marshalledContext
});
Comment thread
bpasero marked this conversation as resolved.

menu.dispose();
}

private _showSessionsPicker(): void {
const picker = this.instantiationService.createInstance(AgentSessionsPicker, undefined, {
overrideSessionOpen: (session, openOptions) => this.activeSessionService.openSession(session.resource, openOptions)
Expand Down
Loading