Agent sessions approval row - #298929
Merged
Benjamin Christopher Simmonds (benibenj) merged 4 commits intoMar 3, 2026
Merged
Conversation
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge
March 3, 2026 10:53
Copilot started reviewing on behalf of
Benjamin Christopher Simmonds (benibenj)
March 3, 2026 10:54
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an “approval row” UI to Agent Sessions so users can explicitly confirm pending tool invocations, backed by a new per-session approval-tracking model.
Changes:
- Introduces
AgentSessionApprovalModelto derive per-session approval info (label/language + confirm action) from live chat tool-invocation state. - Updates the agent sessions tree renderer + delegate to render the approval row and adjust row height dynamically.
- Adds component fixtures and a dedicated unit test suite for the approval model; enables the feature in the Sessions window.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/test/browser/componentFixtures/agentSessionsViewer.fixture.ts | Adds visual fixtures covering many session variants, including approval-row examples. |
| src/vs/workbench/contrib/chat/test/browser/agentSessions/agentSessionApprovalModel.test.ts | Unit tests for approval derivation across tool invocation states and data variants. |
| src/vs/workbench/contrib/chat/browser/agentSessions/media/agentsessionsviewer.css | Styles for the new approval row UI. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts | Renders approval row, emits height-change events, and supports dynamic item height. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsControl.ts | Wires approval model into the sessions tree and updates row height when approval visibility changes. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionApprovalModel.ts | New model that tracks “needs approval” state per session via observables. |
| src/vs/sessions/contrib/sessions/browser/sessionsViewPane.ts | Enables the approval row in the Sessions window. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Copilot i forgot to correctly adjust this test, can you adjust it so it passes again. It should be expecting sh and not bash
AssertionError: {"label":"legacy-cmd","language":"sh"} deepStrictEqual {"label":"legacy-cmd","language":"bash"} |
Contributor
|
Benjamin Christopher Simmonds (@benibenj) I've opened a new pull request, #298933, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * fix: update test expectation for legacy terminal tool data to expect 'sh' language id Co-authored-by: benibenj <44439583+benibenj@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: benibenj <44439583+benibenj@users.noreply.github.com>
Benjamin Pasero (bpasero)
approved these changes
Mar 3, 2026
Benjamin Christopher Simmonds (benibenj)
merged commit Mar 3, 2026
41054e8
into
main
20 checks passed
Benjamin Christopher Simmonds (benibenj)
deleted the
benibenj/resonant-hummingbird
branch
March 3, 2026 12:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Introduce an approval row for agent sessions, allowing for user confirmation on tool invocations. This includes updates to the session model and rendering logic to support the new approval feature.