Skip to content

sessions - always prefer session label #298926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Benjamin Pasero (bpasero) merged 2 commits into from
Mar 3, 2026
Merged

sessions - always prefer session label #298926

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aab87e7
sessions - always prefer session label
bpasero Mar 3, 2026
570dac5
Update src/vs/sessions/contrib/sessions/browser/sessionsTitleBarWidge…
bpasero Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/vs/sessions/contrib/sessions/browser/sessionsTitleBarWidget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,20 +233,18 @@ export class SessionsTitleBarWidget extends BaseActionViewItem {

/**
* Get the label of the active chat session.
* Prefers the live model title over the snapshot label from the active session service.
* Falls back to a generic label if no active session is found.
*/
private _getActiveSessionLabel(): string {
const activeSession = this.activeSessionService.getActiveSession();
if (activeSession?.resource) {
const model = this.chatService.getSession(activeSession.resource);
if (model?.title) {
return model.title;
}
if (activeSession?.label) {
return activeSession?.label; // prefer session label to support renamed sessions
Comment thread
bpasero marked this conversation as resolved.
Outdated
}

if (activeSession?.label) {
return activeSession.label;
if (activeSession) {
const activeModel = this.chatService.getSession(activeSession.resource);
if (activeModel?.title) {
return activeModel.title; // fall back to chat model title if available
}
}

return localize('agentSessions.newSession', "New Session");
Expand Down
Loading