Skip to content

Add Cmd+W keybinding for new chat session in session management #298807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Benjamin Christopher Simmonds (benibenj) merged 4 commits into from
Mar 2, 2026
Merged

Add Cmd+W keybinding for new chat session in session management #298807

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d0367a
Add IsNewChatSessionContext to sessions management service import and…
benibenj Mar 2, 2026
f17a40c
Add secondary keybinding for opening new session with Cmd+W in non-em…
benibenj Mar 2, 2026
8181584
Enhance Cmd+W keybinding condition to require non-empty active editor…
benibenj Mar 2, 2026
38c45cb
Fix Cmd+W keybinding condition to check for visible editors instead o…
benibenj Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/vs/sessions/contrib/sessions/browser/sessionsViewPane.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { MutableDisposable } from '../../../../base/common/lifecycle.js';
import { autorun } from '../../../../base/common/observable.js';
import { ThemeIcon } from '../../../../base/common/themables.js';
import { ContextKeyExpr, IContextKeyService } from '../../../../platform/contextkey/common/contextkey.js';
import { EditorsVisibleContext } from '../../../../workbench/common/contextkeys.js';
import { IContextMenuService } from '../../../../platform/contextview/browser/contextView.js';
import { IInstantiationService, ServicesAccessor } from '../../../../platform/instantiation/common/instantiation.js';
import { IKeybindingService } from '../../../../platform/keybinding/common/keybinding.js';
Expand All @@ -31,7 +32,7 @@ import { AgentSessionProviders } from '../../../../workbench/contrib/chat/browse
import { IPromptsService } from '../../../../workbench/contrib/chat/common/promptSyntax/service/promptsService.js';
import { IMcpService } from '../../../../workbench/contrib/mcp/common/mcpTypes.js';
import { IAICustomizationWorkspaceService } from '../../../../workbench/contrib/chat/common/aiCustomizationWorkspaceService.js';
import { ISessionsManagementService } from './sessionsManagementService.js';
import { ISessionsManagementService, IsNewChatSessionContext } from './sessionsManagementService.js';
import { Action2, ISubmenuItem, MenuId, MenuRegistry, registerAction2 } from '../../../../platform/actions/common/actions.js';
import { HoverPosition } from '../../../../base/browser/ui/hover/hoverWidget.js';
import { IWorkbenchLayoutService } from '../../../../workbench/services/layout/browser/layoutService.js';
Expand Down Expand Up @@ -322,6 +323,16 @@ KeybindingsRegistry.registerKeybindingRule({
primary: KeyMod.CtrlCmd | KeyCode.KeyN,
});

// Register Cmd+W / Ctrl+W to open new session when the current session is non-empty,
Comment thread
benibenj marked this conversation as resolved.
// mirroring how Cmd+W closes the active editor in the normal workbench.
KeybindingsRegistry.registerKeybindingRule({
id: ACTION_ID_NEW_CHAT,
weight: KeybindingWeight.WorkbenchContrib + 1,
when: ContextKeyExpr.and(IsNewChatSessionContext.negate(), EditorsVisibleContext.negate()),
primary: KeyMod.CtrlCmd | KeyCode.KeyW,
win: { primary: KeyMod.CtrlCmd | KeyCode.F4, secondary: [KeyMod.CtrlCmd | KeyCode.KeyW] },
Comment thread
benibenj marked this conversation as resolved.
});

MenuRegistry.appendMenuItem(MenuId.ViewTitle, {
submenu: SessionsViewFilterSubMenu,
title: localize2('filterAgentSessions', "Filter Sessions"),
Expand Down
Loading