Skip to content

sessions - wording #298799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Benjamin Pasero (bpasero) merged 2 commits into from
Mar 2, 2026
Merged

sessions - wording #298799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbd864c
fix - update notification messages to use 'session'
bpasero Mar 2, 2026
e8c65f6
fix - update toast action label to 'Open Session'
bpasero Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/vs/workbench/contrib/chat/browser/chatWindowNotifier.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export class ChatWindowNotifier extends Disposable implements IWorkbenchContribu
}

// Create OS notification
const notificationTitle = info.title ? localize('chatTitle', "Chat: {0}", info.title) : localize('chat.untitledChat', "Untitled Chat");
const notificationTitle = info.title ? localize('chatTitle', "Session: {0}", info.title) : localize('chat.untitledChat', "Untitled Session");

const cts = new CancellationTokenSource();
this._activeNotifications.set(sessionResource, toDisposable(() => cts.dispose(true)));
Expand All @@ -103,7 +103,7 @@ export class ChatWindowNotifier extends Disposable implements IWorkbenchContribu

try {
const actionLabel = isQuestionCarousel
? localize('openChatAction', "Open Chat")
? localize('openChatAction', "Open Session")
Comment thread
bpasero marked this conversation as resolved.
: localize('allowAction', "Allow");

const result = await this._hostService.showToast({
Expand Down
18 changes: 9 additions & 9 deletions src/vs/workbench/contrib/chat/electron-browser/chat.contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ class ChatLifecycleHandler extends Disposable {
}));

this._register(extensionService.onWillStop(e => {
e.veto(this.hasNonCloudSessionInProgress(), localize('chatRequestInProgress', "A chat request is in progress."));
e.veto(this.hasNonCloudSessionInProgress(), localize('chatRequestInProgress', "A session is in progress."));
}));
}

Expand Down Expand Up @@ -182,20 +182,20 @@ class ChatLifecycleHandler extends Disposable {
let detail: string;
switch (reason) {
case ShutdownReason.CLOSE:
message = localize('closeTheWindow.message', "A chat request is in progress. Are you sure you want to close the window?");
detail = localize('closeTheWindow.detail', "The chat request will stop if you close the window.");
message = localize('closeTheWindow.message', "A session is in progress. Are you sure you want to close the window?");
detail = localize('closeTheWindow.detail', "The session will stop if you close the window.");
break;
case ShutdownReason.LOAD:
message = localize('changeWorkspace.message', "A chat request is in progress. Are you sure you want to change the workspace?");
detail = localize('changeWorkspace.detail', "The chat request will stop if you change the workspace.");
message = localize('changeWorkspace.message', "A session is in progress. Are you sure you want to change the workspace?");
detail = localize('changeWorkspace.detail', "The session will stop if you change the workspace.");
break;
case ShutdownReason.RELOAD:
message = localize('reloadTheWindow.message', "A chat request is in progress. Are you sure you want to reload the window?");
detail = localize('reloadTheWindow.detail', "The chat request will stop if you reload the window.");
message = localize('reloadTheWindow.message', "A session is in progress. Are you sure you want to reload the window?");
detail = localize('reloadTheWindow.detail', "The session will stop if you reload the window.");
break;
default:
message = isMacintosh ? localize('quit.message', "A chat request is in progress. Are you sure you want to quit?") : localize('exit.message', "A chat request is in progress. Are you sure you want to exit?");
detail = isMacintosh ? localize('quit.detail', "The chat request will stop if you quit.") : localize('exit.detail', "The chat request will stop if you exit.");
message = isMacintosh ? localize('quit.message', "A session is in progress. Are you sure you want to quit?") : localize('exit.message', "A session is in progress. Are you sure you want to exit?");
detail = isMacintosh ? localize('quit.detail', "The session will stop if you quit.") : localize('exit.detail', "The session will stop if you exit.");
break;
}

Expand Down
Loading