Skip to content

sessions - allow to run sub-app when using cli #298685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Benjamin Pasero (bpasero) merged 2 commits into from
Mar 2, 2026
Merged

sessions - allow to run sub-app when using cli #298685

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d45391
sessions - allow to run sub-app when using cli
bpasero Mar 2, 2026
6dde075
ccr
bpasero Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions src/vs/code/node/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*--------------------------------------------------------------------------------------------*/

import { ChildProcess, spawn, SpawnOptions, StdioOptions } from 'child_process';
import { chmodSync, existsSync, readFileSync, statSync, truncateSync, unlinkSync } from 'fs';
import { chmodSync, existsSync, readFileSync, statSync, truncateSync, unlinkSync, promises } from 'fs';
import { homedir, tmpdir } from 'os';
import type { ProfilingSession, Target } from 'v8-inspect-profiler';
import { Event } from '../../base/common/event.js';
Expand Down Expand Up @@ -499,8 +499,26 @@ export async function main(argv: string[]): Promise<void> {
// This way, Mac does not automatically try to foreground the new instance, which causes
// focusing issues when the new instance only sends data to a previous instance and then closes.
const spawnArgs = ['-n', '-g'];
// -a opens the given application.
spawnArgs.push('-a', process.execPath); // -a: opens a specific application

// Figure out the app to launch: with --sessions we try to launch the embedded app
let appToLaunch = process.execPath;
if (args.sessions) {
// process.execPath is e.g. /Applications/Code.app/Contents/MacOS/Electron
// Embedded app is at /Applications/Code.app/Contents/Applications/<EmbeddedApp>.app
const contentsPath = dirname(dirname(process.execPath));
const applicationsPath = join(contentsPath, 'Applications');
try {
const files = await promises.readdir(applicationsPath);
const embeddedApp = files.find(file => file.endsWith('.app'));
if (embeddedApp) {
appToLaunch = join(applicationsPath, embeddedApp);
argv = argv.filter(arg => arg !== '--sessions');
}
} catch (error) {
/* may not exist on disk */
}
}
spawnArgs.push('-a', appToLaunch); // -a opens the given application.

if (args.verbose || args.status) {
spawnArgs.push('--wait-apps'); // `open --wait-apps`: blocks until the launched app is closed (even if they were already running)
Expand Down
Loading