Skip to content

Fix macOS sidebar traffic light spacer: native titlebar guard + RTL locale support - #298678

Closed
Benjamin Christopher Simmonds (benibenj) with Copilot wants to merge 2 commits into
benibenj/copilot-worktree-2026-03-02T08-58-26from
copilot/sub-pr-298669
Closed

Fix macOS sidebar traffic light spacer: native titlebar guard + RTL locale support#298678
Benjamin Christopher Simmonds (benibenj) with Copilot wants to merge 2 commits into
benibenj/copilot-worktree-2026-03-02T08-58-26from
copilot/sub-pr-298669

Conversation

Copilot AI commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

The Agent Sessions sidebar always rendered a 70px traffic light spacer on macOS, even when the OS was drawing native titlebar/traffic lights (causing double spacing). It also didn't account for RTL locales where macOS moves traffic lights to the right.

  • Gate spacer creation behind !hasNativeTitlebar(this.configurationService) — spacer only appears with custom titlebar
  • Simplify to single-arg hasNativeTitlebar() call (it falls back to getTitleBarStyle internally), drop unused import
  • Add RTL locale detection mirroring TitlebarPart's primaryWindowControlsLocation logic via safeIntl.Locale(platformLocale).textInfo.direction — spacer only added when traffic lights are on the left (LTR)
  • Update LAYOUT.md docs and changelog

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…veTitlebar call

Co-authored-by: benibenj <44439583+benibenj@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix macOS sidebar traffic light spacer rendering with custom titlebar Fix macOS sidebar traffic light spacer: native titlebar guard + RTL locale support Mar 2, 2026
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants