ci: fix electron download from test steps#292811
Merged
Merged
Conversation
Collaborator
Author
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CI test execution to avoid re-downloading/repackaging Electron from the scripts/test.* steps, relying instead on the explicit “Download Electron” pipeline step (follow-up to #292770).
Changes:
- Gate Electron download in
scripts/test.shandscripts/test.batbehindVSCODE_SKIP_PRELAUNCH. - Set
VSCODE_SKIP_PRELAUNCH=1for Electron-based unit/integration test steps in Linux/macOS/Windows product-build pipelines.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/test.sh | Skip npm run electron when VSCODE_SKIP_PRELAUNCH is set. |
| scripts/test.bat | Skip Electron download/bootstrap when VSCODE_SKIP_PRELAUNCH is set. |
| build/azure-pipelines/win32/steps/product-build-win32-test.yml | Set VSCODE_SKIP_PRELAUNCH for Electron unit/integration/remote integration test steps. |
| build/azure-pipelines/linux/steps/product-build-linux-test.yml | Set VSCODE_SKIP_PRELAUNCH for Electron unit/integration/remote integration test steps. |
| build/azure-pipelines/darwin/steps/product-build-darwin-test.yml | Set VSCODE_SKIP_PRELAUNCH for Electron unit/integration/remote integration test steps. |
deepak1556
force-pushed
the
robo/fix_build
branch
from
e1df608 to
0073428
Compare
deepak1556
force-pushed
the
robo/fix_build
branch
from
0073428 to
6c3cd65
Compare
Collaborator
Author
|
Failing tests are unrelated |
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
joshspicer
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #292770
Refs https://dev.azure.com/monacotools/Monaco/_build/results?buildId=402027&view=results