Skip to content

Fix MacOS scripts/code.sh #292729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pwang347 wants to merge 1 commit into from
Closed

Fix MacOS scripts/code.sh #292729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/code.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function code() {

if [[ "$OSTYPE" == "darwin"* ]]; then
NAME=`node -p "require('./product.json').nameLong"`
EXE_NAME=`node -p "require('./product.json').nameShort"`
EXE_NAME="Electron"
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is incomplete. The same issue exists in other scripts that need to be updated as well:

  1. scripts/code-cli.sh (line 15): Still uses node -p "require('./product.json').nameShort"
  2. scripts/node-electron.sh (line 14): Still uses node -p "require('./product.json').nameShort"
  3. scripts/test.sh (line 15): Still uses node -p "require('./product.json').nameShort"

All of these scripts construct paths to the macOS executable in the same way and will fail with the same issue. They should all be updated to use EXE_NAME="Electron" for consistency.

Copilot uses AI. Check for mistakes.
CODE="./.build/electron/$NAME.app/Contents/MacOS/$EXE_NAME"
else
NAME=`node -p "require('./product.json').applicationName"`
Expand Down
Loading