Finalize idToken API #274464
Merged
Finalize idToken API #274464
+8
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request promotes the idToken property from a proposed API to a stable API by moving it from vscode.proposed.idToken.d.ts into the main vscode.d.ts file. This allows all extensions to access ID tokens without needing to opt into a proposed API.
Key Changes
- Moves
idTokenproperty from proposed API to stable API inAuthenticationSessioninterface - Enhances documentation for both
accessTokenandidTokenproperties with references to their respective specifications - Removes the
idTokenproposal file and all references to it from the extension system
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.idToken.d.ts | Completely removed the proposed API file |
| src/vscode-dts/vscode.d.ts | Added idToken property to AuthenticationSession with enhanced documentation |
| src/vs/platform/extensions/common/extensionsApiProposals.ts | Removed idToken from the registry of API proposals |
| extensions/microsoft-authentication/tsconfig.json | Removed reference to the proposed API file |
| extensions/microsoft-authentication/package.json | Removed idToken from enabled API proposals |
alexr00
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was actually code gate for this API because it was just what was returned by the auth provider. Microsoft auth provider returns these.
Fixes #140929