Update node-pty version for conpty 1.23.251008001 #274387
Conversation
| "native-keymap": "^3.3.5", | ||
| "native-watchdog": "^1.4.1", | ||
| "node-pty": "1.1.0-beta35", | ||
| "node-pty": "1.1.0-beta38", |
There was a problem hiding this comment.
Need to also update remote/package.json for node-pty as it's shipped with the server.
There was a problem hiding this comment.
Silly question.. I just realized for remote/ package-lock.json, I had to manually edit the version number.
Usually npm install would update package-lock.json . But for remote is it manual like this?
There was a problem hiding this comment.
I always run npm install node-pty@... in both repos to update. Note that we need the update to go in also for microsoft/node-pty#812 now
There was a problem hiding this comment.
Pull Request Overview
This PR updates the node-pty dependency from version 1.1.0-beta35 to 1.1.0-beta38 and updates the conpty.dll version reference in the terminal configuration description to reflect the newer version shipped with the updated package.
Key Changes
- Updated
node-ptyfrom1.1.0-beta35to1.1.0-beta38across all package manifests - Updated conpty.dll version reference from
v1.22.250204002tov1.23.251008001in the terminal configuration description
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts | Updated conpty.dll version reference in the windowsUseConptyDll setting description |
| remote/package.json | Updated node-pty dependency version |
| remote/package-lock.json | Updated node-pty lock file entry |
| package.json | Updated node-pty dependency version |
| package-lock.json | Updated node-pty lock file entries with new version, resolved URL, and integrity hash |
Files not reviewed (1)
- remote/package-lock.json: Language not supported
|
Closing in favor of #274736 |
Pull request was closed
This is so we get microsoft/node-pty#811
Also updating conpty dll version number defined in setting description.