-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand docs on the side in the suggest widget #25812
Conversation
@ramya-rao-a, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joaomoreno and @jrieken to be potential reviewers. |
I'll file individual issues for the problems I find. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks OK. I filed a few issues. Nothing blocking in my opinion, just a lot of tweaking. I'll leave the merge decision up to you.
@@ -23,7 +23,13 @@ | |||
|
|||
.monaco-editor .suggest-widget > .tree { | |||
height: 100%; | |||
width: 100%; | |||
width: 40%; | |||
float: left; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Careful with floats. If all you have is two divs, you should use the usual inline-block
display to lay them out side by side.
First draft for #18582
Features in the PR:
suggestion.details
orsuggestion.documentation
exist, they will appear on the side of the suggest list. If no docs but details match then label, then the docs section is not shownctrl+space
and then page up and down as usualPending:
Update as of 5/7: Logic to decide when to swap list and docs, where to position the suggest widget and when to re-size the docs is finalized here: https://github.com/Microsoft/vscode/blob/ramyar/docs-on-the-side/src/vs/editor/contrib/suggest/browser/suggestWidget.ts#L817