Skip to content

Comments

ESM for extensions#245214

Merged
jrieken merged 8 commits intomainfrom
joh/aggregate-cod
Apr 1, 2025
Merged

ESM for extensions#245214
jrieken merged 8 commits intomainfrom
joh/aggregate-cod

Conversation

@jrieken
Copy link
Member

@jrieken jrieken commented Apr 1, 2025

This is for #130367 and adds native ESM support for extensions.

  • use import to load extensions (when they signal ESM support via type: module or the .mjs suffix
  • enables import('vscode') for extensions the same way require('vscode') works
  • enables other, regular ESM imports
  • enables ESM extension tests

Support is ONLY for the nodejs extension host and not yet for the web worker extension host.

@jrieken jrieken self-assigned this Apr 1, 2025
@jrieken jrieken enabled auto-merge (squash) April 1, 2025 08:06
@jrieken jrieken added this to the April 2025 milestone Apr 1, 2025
lszomoru
lszomoru previously approved these changes Apr 1, 2025
@jrieken jrieken merged commit 15260e7 into main Apr 1, 2025
8 checks passed
@jrieken jrieken deleted the joh/aggregate-cod branch April 1, 2025 09:08
@kieferrm kieferrm mentioned this pull request Apr 10, 2025
64 tasks
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants