Fix White flash issue in window.ts (#132339)

[adityaonx]

Fixes #132339

I modified this line, so the white flash won't occur when opening VS Code in maximized window happening in Windows OS.

• Previous code: Line 140

• Updated code: Line 142

Before

1IssueVid.mp4

After

1IssueFix.mp4

[bpasero]

@adityaonx thanks a bunch for getting us a bit closer to solve this puzzle. however I think now we are trading the white flash issue with seeing a normal sized window growing to maximize state on startup, which is also annoying. Given what you found out I would like to take this back to the Electron issue and ask what is going on 🙏

[adityaonx]

@adityaonx thanks a bunch for getting us a bit closer to solve this puzzle. however I think now we are trading the white flash issue with seeing a normal sized window growing to maximize state on startup, which is also annoying. Given what you found out I would like to take this back to the Electron issue and ask what is going on 🙏

Thanks a ton for developing the VS Code.
However, this white flash bug has created inconvenience to some of the people including me, having it while working daily with VS Code.

To come up with this workaround mentioned above, I experimented with some values which deals with electron window handler.

This white flash issue in windows electron apps comes from chromium and a fix is being discussed in the following:
(https://chromium-review.googlesource.com/c/chromium/src/+/6092335?tab=comments)
(https://issues.chromium.org/issues/41241478).

Suggestions from one of chromium dev was to add an acrylic/mica background before loading actual window.
Currently working command line that fixes white flash in Edge Stable release is "--enable-features=RemoveRedirectionBitmap".

From what I understood is if we can display a mica/acrylic background before actually displaying the loaded VS Code can replace this white window.

[kristianka]

Sadly no updates since January in those issue trackers. Could this be considered as a temporary fix until a proper one is made from the Chromium developers? Tired of the white flashbangs on my Windows machine... 😅

[adityaonx]

Sadly no updates since January in those issue trackers. Could this be considered as a temporary fix until a proper one is made from the Chromium developers? Tired of the white flashbangs on my Windows machine... 😅

Well these flashes are everywhere! From Most of Chromium based apps to some Windows Native Apps. The root problem is in the rendering of White page in Windows DWM itself.

[adityaonx]

Sadly no updates since January in those issue trackers. Could this be considered as a temporary fix until a proper one is made from the Chromium developers? Tired of the white flashbangs on my Windows machine... 😅

A workaround to avoid all flashes from chrome to VScode is to use stardock's WindowFX application which will modify DWM and will have custom animations added to transitions and will avoid the white flashes!

[adityaonx]

Closed #245208 as
#132339 closed as completed via #249241.