Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize paste api and drop api tweaks #237443

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Jan 7, 2025

Fixes #30066

This finalizes the documentPaste api. This api allows extensions to attach metadata on text copy and change how content is pasted. Some examples:

  • Updating imports for pasted code
  • Inserting an image as an attachment in notebooks
  • Pasting files converts them to relative text paths

Fixes microsoft#30066

This finalizes the documentPaste api. This api allows extensions to attach metadata on text copy and change how content is pasted. Some examples:

- Updating imports for pasted code
- Inserting an image as an attachment in notebooks
- Pasting files converts them to relative text paths
@mjbvz mjbvz self-assigned this Jan 7, 2025
@mjbvz mjbvz requested a review from jrieken as a code owner January 7, 2025 22:57
@mjbvz mjbvz added this to the January 2025 milestone Jan 7, 2025
@mjbvz mjbvz enabled auto-merge January 7, 2025 22:57
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@mjbvz Minor nit: we have a mix of export interface IFoo vs interface IBar and we should invest in a lint rule for this

@mjbvz mjbvz merged commit 23b62bc into microsoft:main Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add events for copy/paste to allow language extensions to bring using/import statements along
2 participants